Add manual publish control to CI workflow#241
Merged
Conversation
…se flag Add a workflow_dispatch boolean input 'publish_release' (default false) and require it on the publish-release job in addition to the existing v* tag guard. A v* tag push alone no longer auto-publishes to Maven Central; releasing now requires running the Publish workflow on the v* tag with publish_release enabled (tag AND flag). publish-snapshot is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JGZdUCy6YnTzKSJKA6B6KZ
…SHOT Add a guard step to the publish-snapshot job that resolves project.version via `mvn help:evaluate` and fails the job unless the version ends in -SNAPSHOT. central-publishing routes purely by version: a release version (no -SNAPSHOT) deployed through the snapshot path lands in the permanent Maven Central release store, not the snapshot store. This guard stops that from ever happening from the snapshot job; releases continue to go through the v* tag path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JGZdUCy6YnTzKSJKA6B6KZ
…h_to_central flag Generalize the release-only publish_release input into a general publish_to_central boolean and require it on BOTH publish-snapshot and publish-release, matching the BitcoinAddressFinder sibling pipeline. Central publishing now runs only from a manual workflow_dispatch with the flag enabled; pushes to main and v* tag pushes no longer auto-deploy. Snapshot vs release is still decided by the POM version, and the -SNAPSHOT guard added in the previous commit blocks a release version from ever shipping via the snapshot job. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JGZdUCy6YnTzKSJKA6B6KZ
bernardladenthin
had a problem deploying
to
startgate
GitHub Actions
Error
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish_to_centralboolean input toworkflow_dispatchto allow manual control over Maven Central publishing-SNAPSHOTversion in snapshot publish job to prevent accidental release version deploymentsTest plan
Related issues / PRs
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdSECURITY.md)Details
This change adds safety guards to the Maven Central publishing workflow:
Manual dispatch control: The
workflow_dispatchtrigger now accepts apublish_to_centralboolean input (default:false), allowing developers to manually trigger the workflow without automatically publishing artifacts.Snapshot version guard: The
publish-snapshotjob now includes a validation step that ensures the project version ends with-SNAPSHOTbefore deploying. This prevents accidentally publishing release versions through the snapshot pipeline.Gated publish jobs: Both
publish-snapshotandpublish-releasejobs now requireinputs.publish_to_centralto be true, in addition to their existing checks (check-snapshotandcheck-tagresults).These changes improve safety by preventing unintended artifact deployments while maintaining the existing tag-based release automation.
https://claude.ai/code/session_01JGZdUCy6YnTzKSJKA6B6KZ