return the response of an IaC template deployment? is there a world?

Author: bernardodemarco

plugins/iac/nimble/src/main/java/org/apache/cloudstack/service/NimbleManagerImpl.java

@@ -438,7 +438,8 @@ public void deployIacTemplate(DeployIacTemplateCmd cmd) {
         Map<String, String> inputs = cmd.getInputs();
         IacTemplate iacTemplate = findIacTemplateById(cmd.getId());
         checkCallerAccessToIacTemplate(CallContext.current(), iacTemplate);
-        toscaOrchestrator.deployIacTemplate(iacTemplate.getIacTemplateContent(), inputs, cmd.getHttpMethod());
+        ToscaServiceTemplate serviceTemplate = toscaOrchestrator.deployIacTemplate(iacTemplate.getIacTemplateContent(), inputs, cmd.getHttpMethod());
+        logger.info("WILL IT WORK?????", serviceTemplate);
     }
 
     @Override

plugins/iac/nimble/src/main/java/org/apache/cloudstack/tosca/model/ToscaNodeTemplate.java

@@ -29,6 +29,12 @@ public class ToscaNodeTemplate {
     private final Set<ToscaProperty> unresolvedPropertiesByGetAttribute = new HashSet<>();
     private final Map<String, Object> attributes = new HashMap<>();
 
+    public enum ProvisioningState {
+        PENDING, SUCCEEDED, FAILED, CANCELLED
+    }
+
+    private volatile ProvisioningState provisioningState = ProvisioningState.PENDING;
+
     public ToscaNodeTemplate(String name, ToscaNodeType type, Map<String, ToscaProperty> properties) {
         this.name = name;
         this.type = type;
@@ -92,4 +98,12 @@ public Object getAttribute(String name) {
     public Map<String, Object> getAttributes() {
         return attributes;
     }
+
+    public ProvisioningState getProvisioningState() {
+        return provisioningState;
+    }
+
+    public void setProvisioningState(ProvisioningState provisioningState) {
+        this.provisioningState = provisioningState;
+    }
 }

plugins/iac/nimble/src/main/java/org/apache/cloudstack/tosca/orchestrator/ToscaOrchestrator.java

@@ -104,7 +104,7 @@ public class ToscaOrchestrator {
 
     private ExecutorService executorPool;
 
-    public void deployIacTemplate(String iacTemplateContent, Map<String, String> inputs, BaseCmd.HTTPMethod httpMethod) {
+    public ToscaServiceTemplate deployIacTemplate(String iacTemplateContent, Map<String, String> inputs, BaseCmd.HTTPMethod httpMethod) {
         ToscaServiceTemplate serviceTemplate = parseServiceTemplate(iacTemplateContent);
         resolveServiceTemplateInputs(serviceTemplate, inputs);
 
@@ -114,6 +114,7 @@ public void deployIacTemplate(String iacTemplateContent, Map<String, String> inp
         getCurrentNimbleExecutorPoolStatus("before creating provisioning tasks");
         provisioningTasksFutures.putAll(createProvisioningTasksFutures(serviceTemplate, errors, cancelAllProvisioningTasks, httpMethod));
         awaitDeployCompletion(provisioningTasksFutures, errors, cancelAllProvisioningTasks);
+        return serviceTemplate;
     }
 
     public ToscaServiceTemplate parseServiceTemplate(String iacTemplateContent) {
@@ -221,7 +222,7 @@ private Map<String, CompletableFuture<Void>> createProvisioningTasksFutures(Tosc
             }
 
             taskFuture.whenComplete((result, ex) -> {
-                handleTaskCompletion(ex, errors, cancelAllProvisioningTasks);
+                handleTaskCompletion(nodeTemplate, ex, errors, cancelAllProvisioningTasks);
                 getCurrentNimbleExecutorPoolStatus(String.format("after node template [%s] provisioning", node));
             });
 
@@ -232,23 +233,27 @@ private Map<String, CompletableFuture<Void>> createProvisioningTasksFutures(Tosc
         return futures;
     }
 
-    private void handleTaskCompletion(Throwable ex, List<Throwable> errors, Runnable cancelAllProvisioningTasks) {
+    private void handleTaskCompletion(ToscaNodeTemplate nodeTemplate, Throwable ex, List<Throwable> errors, Runnable cancelAllProvisioningTasks) {
         if (ex == null) {
             logger.trace("The provisioning of the node template completed successfully. Skipping error handling.");
+            nodeTemplate.setProvisioningState(ToscaNodeTemplate.ProvisioningState.SUCCEEDED);
             return;
         }
 
         if (ex instanceof CompletionException) {
             ex = ex.getCause();
         }
 
-        if (!(ex instanceof CancellationException)) {
-            logger.trace("An error occurred during the provisioning of a node template. Adding it to the list of errors.", ex);
-            errors.add(ex);
-            cancelAllProvisioningTasks.run();
-        } else {
+        if (ex instanceof CancellationException) {
             logger.trace("The provisioning of the node template was cancelled. Skipping error handling.", ex);
+            nodeTemplate.setProvisioningState(ToscaNodeTemplate.ProvisioningState.CANCELLED);
+            return;
         }
+
+        logger.trace("An error occurred during the provisioning of a node template. Adding it to the list of errors.", ex);
+        nodeTemplate.setProvisioningState(ToscaNodeTemplate.ProvisioningState.FAILED);
+        errors.add(ex);
+        cancelAllProvisioningTasks.run();
     }
 
     // O(|V|+|E|)