Improvement: Get rid of legacy code for moodleversionminfourtwo CSS stylings.

Author: bernhard-wunderbyte

classes/output/table.php

@@ -807,11 +807,6 @@ public function return_as_list() {
             $data['shoppingcartisavailable'] = true;
         }
 
-        // We need a param to check in the css if the version is minimum 4.2.
-        if ($CFG->version >= 2023042400) {
-            $data['moodleversionminfourtwo'] = 'moodleversionminfourtwo';
-        }
-
         // Make sure switchtemplates array is not passed, if it's empty.
         if (empty($this->switchtemplates)) {
             $data['switchtemplates'] = null;

styles.css

@@ -167,28 +167,15 @@
 .wunderbyte-table-table th[data-sortable]::before {
     content: "\f0de";
     font-size: 14px;
-    font-family: 'FontAwesome', 'Font Awesome 6 Free';
-    top: 35%;
-    right: 0;
-}
-
-.wunderbyte-table-table th[data-sortable]::after {
-    content: "\f0d7";
-    font-size: 14px;
-    font-family: 'FontAwesome', 'Font Awesome 6 Free';
-    top: 40%;
-}
-
-.wunderbyte-table-table.moodleversionminfourtwo th[data-sortable]::before {
-    content: "\f0de";
     font: var(--fa-font-solid);
     font-family: 'FontAwesome', 'Font Awesome 6 Free';
     top: 35%;
     right: 0;
 }
 
-.wunderbyte-table-table.moodleversionminfourtwo th[data-sortable]::after {
+.wunderbyte-table-table th[data-sortable]::after {
     content: "\f0dd";
+    font-size: 14px;
     font: var(--fa-font-solid);
     font-family: 'FontAwesome', 'Font Awesome 6 Free';
     top: 40%;

templates/twtable_cards.mustache

@@ -91,7 +91,7 @@
                <div class="float-end">{{> local_wunderbyte_table/component_selectrows }}</div>
           </div>
      {{/displayelementsontop}}
-     <div class="wunderbyte-table-table {{moodleversionminfourtwo}}">
+     <div class="wunderbyte-table-table">
           {{> local_wunderbyte_table/component_countlabel }}
           {{#table}}
                <div class="wunderbyte-table-grid no-overflow rows-container">

templates/twtable_list.mustache

@@ -91,7 +91,7 @@
                <div class="float-end">{{> local_wunderbyte_table/component_selectrows }}</div>
           </div>
      {{/displayelementsontop}}
-     <div class="wunderbyte-table-table {{moodleversionminfourtwo}}">
+     <div class="wunderbyte-table-table">
           {{> local_wunderbyte_table/component_countlabel }}
           <div {{#stickyheader}} class="scroll-y" {{#tableheight}}
           style="height: {{tableheight}}px;" {{/tableheight}}{{/stickyheader}}>