Skip to content

feat: add ROWID column type (type# 69) decoding #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rophy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add ROWID column type (type# 69) decoding #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/builder/Builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,32 @@ namespace OpenLogReplicator {
}
break;

case SysCol::COLTYPE::ROWID:
// ROWID (type 69) in redo: 10 bytes big-endian
// dataObj(4) + DBA(4, afn<<22|block) + slot(2)
// Output as Oracle base64 ROWID string (e.g. AAASnuAAMAAAAKtAAA)
if (size == 10) {
const typeDataObj rDataObj = (static_cast<typeDataObj>(data[0]) << 24) |
(static_cast<typeDataObj>(data[1]) << 16) |
(static_cast<typeDataObj>(data[2]) << 8) |
static_cast<typeDataObj>(data[3]);
const typeDba rDba = (static_cast<typeDba>(data[4]) << 24) |
(static_cast<typeDba>(data[5]) << 16) |
(static_cast<typeDba>(data[6]) << 8) |
static_cast<typeDba>(data[7]);
const typeSlot rSlot = (static_cast<typeSlot>(data[8]) << 8) |
static_cast<typeSlot>(data[9]);
RowId rowId(rDataObj, rDba, rSlot);
// Output as base64 string (Oracle's standard ROWID display format)
// Not using columnRowId — that uses toHex for UROWID compatibility
rowId.toString(reinterpret_cast<char*>(valueBuffer));
valueSize = RowId::SIZE;
columnString(column->name);
} else {
columnUnknown(column->name, data, size);
}
break;

case SysCol::COLTYPE::UROWID:
if (size == 13 && data[0] == 0x01) {
RowId rowId;
Expand Down
6 changes: 6 additions & 0 deletions src/builder/BuilderJson.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ namespace OpenLogReplicator {
&& typeNo != SysCol::COLTYPE::TIMESTAMP
&& typeNo != SysCol::COLTYPE::INTERVAL_YEAR_TO_MONTH
&& typeNo != SysCol::COLTYPE::INTERVAL_DAY_TO_SECOND
&& typeNo != SysCol::COLTYPE::ROWID
&& typeNo != SysCol::COLTYPE::UROWID
&& typeNo != SysCol::COLTYPE::TIMESTAMP_WITH_LOCAL_TZ)
return;
Expand Down Expand Up @@ -501,6 +502,11 @@ namespace OpenLogReplicator {
appendDec(table->columns[column]->length);
break;

case SysCol::COLTYPE::ROWID:
append(std::string_view(R"("rowid","length":)"));
appendDec(table->columns[column]->length);
break;

case SysCol::COLTYPE::UROWID:
append(std::string_view(R"("urowid","length":)"));
appendDec(table->columns[column]->length);
Expand Down
6 changes: 6 additions & 0 deletions src/builder/BuilderProtobuf.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ namespace OpenLogReplicator {
&& typeNo != SysCol::COLTYPE::TIMESTAMP
&& typeNo != SysCol::COLTYPE::INTERVAL_YEAR_TO_MONTH
&& typeNo != SysCol::COLTYPE::INTERVAL_DAY_TO_SECOND
&& typeNo != SysCol::COLTYPE::ROWID
&& typeNo != SysCol::COLTYPE::UROWID
&& typeNo != SysCol::COLTYPE::TIMESTAMP_WITH_LOCAL_TZ)
return;
Expand Down Expand Up @@ -302,6 +303,11 @@ namespace OpenLogReplicator {
columnPB->set_length(static_cast<int32_t>(table->columns[column]->length));
break;

case SysCol::COLTYPE::ROWID:
columnPB->set_type(pb::UROWID);
columnPB->set_length(static_cast<int32_t>(table->columns[column]->length));
break;

case SysCol::COLTYPE::UROWID:
columnPB->set_type(pb::UROWID);
columnPB->set_length(static_cast<int32_t>(table->columns[column]->length));
Expand Down
1 change: 1 addition & 0 deletions src/common/table/SysCol.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ namespace OpenLogReplicator {
RAW = 23,
LONG_RAW = 24,
XMLTYPE = 58,
ROWID = 69,
CHAR = 96,
FLOAT = 100,
DOUBLE = 101,
Expand Down