Skip to content

Commit 36880d8

Browse files
authored
Fix run_tpcds data dir (apache#19771)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Running ` ./bench.sh run tpcds` with a freshly created `./bench.sh data tpcds` fails with the following error: ``` Please prepare TPC-DS data first by following instructions: ./bench.sh data tpcds ``` This PR fixes it ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Fixes the `TPCDS_DIR` variable in `run_tpcds` ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> just benchmark scripts ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> no need
1 parent 803cce8 commit 36880d8

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

benchmarks/bench.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,7 @@ run_tpch_mem() {
683683

684684
# Runs the tpcds benchmark
685685
run_tpcds() {
686-
TPCDS_DIR="${DATA_DIR}"
686+
TPCDS_DIR="${DATA_DIR}/tpcds_sf1"
687687

688688
# Check if TPCDS data directory and representative file exists
689689
if [ ! -f "${TPCDS_DIR}/web_site.parquet" ]; then

0 commit comments

Comments
 (0)