Treat PHPDoc types as certain

Author: jeromegamez

phpstan.neon.dist

@@ -21,13 +21,12 @@ parameters:
 			identifier: staticMethod.dynamicCall
 			path: tests
 
-	checkUninitializedProperties: true
-
 	checkBenevolentUnionTypes: true
 	checkTooWideReturnTypesInProtectedAndPublicMethods: true
+	checkUninitializedProperties: true
 	reportAlwaysTrueInLastCondition: true
 	reportPossiblyNonexistentConstantArrayOffset: true
-	treatPhpDocTypesAsCertain: false
+
 includes:
 	- vendor/cuyz/valinor/qa/PHPStan/valinor-phpstan-configuration.php
 	- vendor/phpstan/phpstan/conf/bleedingEdge.neon

src/Firebase/Auth/ActionCodeSettings/ValidatedActionCodeSettings.php

@@ -60,9 +60,7 @@ public static function fromArray(array $settings): self
             switch (mb_strtolower($key)) {
                 case 'continueurl':
                 case 'url':
-                    $instance->continueUrl = ($value !== null)
-                        ? Utils::uriFor(self::ensureNonEmptyString($value))
-                        : null;
+                    $instance->continueUrl = Utils::uriFor(self::ensureNonEmptyString($value));
 
                     break;
 

src/Firebase/Messaging/AppInstance.php

@@ -38,7 +38,7 @@ public static function fromRawData(RegistrationToken $registrationToken, array $
         $subscriptions = [];
 
         foreach ($rawData['rel']['topics'] ?? [] as $topicName => $subscriptionInfo) {
-            $topic = Topic::fromValue((string) $topicName);
+            $topic = Topic::fromValue($topicName);
             $addedAt = DT::toUTCDateTimeImmutable($subscriptionInfo['addDate'] ?? null);
             $subscriptions[] = new TopicSubscription($topic, $registrationToken, $addedAt);
         }

src/Firebase/RemoteConfig/Template.php

@@ -244,12 +244,12 @@ private static function buildParameter(string $name, array $data): Parameter
         $valueType = ParameterValueType::tryFrom($data['valueType'] ?? '') ?? ParameterValueType::UNSPECIFIED;
 
         $parameter = Parameter::named($name)
-            ->withDescription((string) ($data['description'] ?? ''))
+            ->withDescription($data['description'] ?? '')
             ->withDefaultValue($data['defaultValue'] ?? null)
             ->withValueType($valueType)
         ;
 
-        foreach ((array) ($data['conditionalValues'] ?? []) as $key => $conditionalValueData) {
+        foreach (($data['conditionalValues'] ?? []) as $key => $conditionalValueData) {
             $parameter = $parameter->withConditionalValue(new ConditionalValue($key, ParameterValue::fromArray($conditionalValueData)));
         }
 
@@ -263,7 +263,7 @@ private static function buildParameter(string $name, array $data): Parameter
     private static function buildParameterGroup(string $name, array $parameterGroupData): ParameterGroup
     {
         $group = ParameterGroup::named($name)
-            ->withDescription((string) ($parameterGroupData['description'] ?? ''))
+            ->withDescription($parameterGroupData['description'] ?? '')
         ;
 
         foreach ($parameterGroupData['parameters'] as $parameterName => $parameterData) {

src/Firebase/Valinor/Source.php

@@ -57,11 +57,17 @@ public static function file(string $value): self
             throw new InvalidArgumentException(message: $e->getMessage(), previous: $e);
         }
 
-        $content = $file->fread($file->getSize());
+        $fileSize = $file->getSize();
         $pathName = $file->getPathname();
 
+        if (!is_int($fileSize)) {
+            throw new InvalidArgumentException("Unable to get filesize of `$pathName`");
+        }
+
+        $content = $file->fread($fileSize);
+
         if ($content === false) {
-            throw new InvalidArgumentException("Unable to parse `$pathName`");
+            throw new InvalidArgumentException("Unable to read `$pathName`");
         }
 
         return self::json($content);

tests/Unit/Http/HttpClientOptionsTest.php

@@ -103,8 +103,6 @@ public function itAcceptsSingleCallableMiddlewares(): void
         $middlewares = $options->guzzleMiddlewares();
 
         $this->assertCount(1, $middlewares);
-        $this->assertIsCallable($middlewares[0]['middleware']);
-        $this->assertSame('name', $middlewares[0]['name']);
     }
 
     #[Test]
@@ -128,13 +126,8 @@ public static function handle(): void
 
         $this->assertCount(3, $middlewares);
 
-        $this->assertIsCallable($middlewares[0]['middleware']);
         $this->assertSame('', $middlewares[0]['name']);
-
-        $this->assertIsCallable($middlewares[1]['middleware']);
         $this->assertSame('Foo', $middlewares[1]['name']);
-
-        $this->assertIsCallable($middlewares[2]['middleware']);
         $this->assertSame('Bar', $middlewares[2]['name']);
     }
 

tests/Unit/ServiceAccountTest.php

@@ -6,13 +6,15 @@
 
 use Kreait\Firebase\ServiceAccount;
 use Kreait\Firebase\Valinor\Mapper;
+use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
 use PHPUnit\Framework\TestCase;
 
 final class ServiceAccountTest extends TestCase
 {
     /**
      * @see https://github.com/kreait/firebase-php/pull/1034
      */
+    #[DoesNotPerformAssertions]
     public function testItCanBeMapped(): void
     {
         $mapper = (new Mapper())->allowSuperfluousKeys()->snakeToCamelCase();
@@ -24,8 +26,6 @@ public function testItCanBeMapped(): void
             'private_key' => 'private-key',
         ];
 
-        $serviceAccount = $mapper->map(ServiceAccount::class, $input);
-
-        $this->assertInstanceOf(ServiceAccount::class, $serviceAccount);
+        $mapper->map(ServiceAccount::class, $input);
     }
 }