Drop exception code when wrapping exceptions

`Throwable::getCode()` can be non-int.

Author: jeromegamez

phpstan.neon.dist

@@ -23,6 +23,7 @@ parameters:
 
 	checkUninitializedProperties: true
 
+	checkBenevolentUnionTypes: true
 	checkTooWideReturnTypesInProtectedAndPublicMethods: true
 	reportAlwaysTrueInLastCondition: true
 	reportPossiblyNonexistentConstantArrayOffset: true

src/Firebase/AppCheck/AppCheckTokenVerifier.php

@@ -61,9 +61,9 @@ private function decodeJwt(string $token): DecodedAppCheckToken
             /** @var DecodedAppCheckTokenShape $payload */
             $payload = (array) JWT::decode($token, $this->keySet);
         } catch (LogicException $e) {
-            throw new InvalidAppCheckToken($e->getMessage(), $e->getCode(), $e);
+            throw new InvalidAppCheckToken(message: $e->getMessage(), previous: $e);
         } catch (Throwable $e) {
-            throw new FailedToVerifyAppCheckToken($e->getMessage(), $e->getCode(), $e);
+            throw new FailedToVerifyAppCheckToken(message: $e->getMessage(), previous: $e);
         }
 
         return DecodedAppCheckToken::fromArray($payload);

src/Firebase/Auth.php

@@ -312,13 +312,13 @@ public function sendEmailActionLink(string $type, Stringable|string $email, $act
             try {
                 $user = $this->getUserByEmail($email);
             } catch (Throwable $e) {
-                throw new FailedToSendActionLink($e->getMessage(), $e->getCode(), $e);
+                throw new FailedToSendActionLink(message: $e->getMessage(), previous: $e);
             }
 
             try {
                 $signInResult = $this->signInAsUser($user);
             } catch (Throwable $e) {
-                throw new FailedToSendActionLink($e->getMessage(), $e->getCode(), $e);
+                throw new FailedToSendActionLink(message: $e->getMessage(), previous: $e);
             }
 
             $idToken = $signInResult->idToken();

src/Firebase/Auth/CreateActionLink/GuzzleApiClientHandler.php

@@ -40,7 +40,10 @@ public function handle(CreateActionLink $action): string
         try {
             $response = $this->client->send($request, ['http_errors' => false]);
         } catch (ClientExceptionInterface $e) {
-            throw new FailedToCreateActionLink('Failed to create action link: '.$e->getMessage(), $e->getCode(), $e);
+            throw new FailedToCreateActionLink(
+                message: 'Failed to create action link: '.$e->getMessage(),
+                previous: $e
+            );
         }
 
         if ($response->getStatusCode() !== 200) {
@@ -50,7 +53,10 @@ public function handle(CreateActionLink $action): string
         try {
             $data = Json::decode((string) $response->getBody(), true);
         } catch (InvalidArgumentException $e) {
-            throw new FailedToCreateActionLink('Unable to parse the response data: '.$e->getMessage(), $e->getCode(), $e);
+            throw new FailedToCreateActionLink(
+                message: 'Unable to parse the response data: '.$e->getMessage(),
+                previous: $e
+            );
         }
 
         $actionCode = $data['oobLink'] ?? null;

src/Firebase/Auth/SendActionLink/GuzzleApiClientHandler.php

@@ -39,7 +39,10 @@ public function handle(SendActionLink $action): void
         try {
             $response = $this->client->send($request, ['http_errors' => false]);
         } catch (ClientExceptionInterface $e) {
-            throw new FailedToSendActionLink('Failed to send action link: '.$e->getMessage(), $e->getCode(), $e);
+            throw new FailedToSendActionLink(
+                message: 'Failed to send action link: '.$e->getMessage(),
+                previous: $e
+            );
         }
 
         if ($response->getStatusCode() !== 200) {

src/Firebase/Auth/SignIn/FailedToSignIn.php

@@ -37,7 +37,10 @@ public static function withActionAndResponse(SignIn $action, ResponseInterface $
 
     public static function fromPrevious(Throwable $e): self
     {
-        return new self('Sign in failed: '.$e->getMessage(), $e->getCode(), $e);
+        return new self(
+            message: 'Sign in failed: '.$e->getMessage(),
+            previous: $e
+        );
     }
 
     public function action(): ?SignIn

src/Firebase/Database.php

@@ -38,7 +38,7 @@ public function getReference(?string $path = null): Reference
         try {
             return new Reference($this->uri->withPath($path), $this->client);
         } catch (\InvalidArgumentException $e) {
-            throw new InvalidArgumentException($e->getMessage(), $e->getCode(), $e);
+            throw new InvalidArgumentException(message: $e->getMessage(), previous: $e);
         }
     }
 

src/Firebase/Database/Query.php

@@ -84,7 +84,11 @@ public function getSnapshot(): Snapshot
         } catch (DatabaseNotFound $e) {
             throw $e;
         } catch (DatabaseException $e) {
-            throw new UnsupportedQuery($this, $e->getMessage(), $e->getCode(), $e->getPrevious());
+            throw new UnsupportedQuery(
+                query: $this,
+                message: $e->getMessage(),
+                previous: $e->getPrevious()
+            );
         }
 
         if ($this->sorter !== null) {

src/Firebase/Database/Reference.php

@@ -106,7 +106,7 @@ public function getChild(string $path): self
         try {
             return new self($this->uri->withPath($childPath), $this->apiClient);
         } catch (\InvalidArgumentException $e) {
-            throw new InvalidArgumentException($e->getMessage(), $e->getCode(), $e);
+            throw new InvalidArgumentException(message: $e->getMessage(), previous: $e);
         }
     }
 

src/Firebase/Exception/AppCheckApiExceptionConverter.php

@@ -29,10 +29,13 @@ public function convertException(Throwable $exception): AppCheckException
         }
 
         if ($exception instanceof NetworkExceptionInterface) {
-            return new ApiConnectionFailed('Unable to connect to the API: '.$exception->getMessage(), $exception->getCode(), $exception);
+            return new ApiConnectionFailed(
+                message: 'Unable to connect to the API: '.$exception->getMessage(),
+                previous: $exception
+            );
         }
 
-        return new AppCheckError($exception->getMessage(), $exception->getCode(), $exception);
+        return new AppCheckError(message: $exception->getMessage(), previous: $exception);
     }
 
     private function convertGuzzleRequestException(RequestException $e): AppCheckException