Fix: pass when no CF value is selectable for a CF depending on another CF's value#2
Open
brunetton wants to merge 1 commit into
Open
Fix: pass when no CF value is selectable for a CF depending on another CF's value#2brunetton wants to merge 1 commit into
brunetton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
This PR fixes a case we had to handle in one of our client's RT instance.
First of all, I'm sorry not to have written tests for this particular case; I'm don't feel yet comfortable enough to write tests for RT.
The problem fixed here appears when a CF that values depends on another CF's values have no selectable value.
The plugin block from validating transition, requireing a value for the CF that do not exists.
Steps to reproduce problem
define a CF named
cf1with values:define another CF named
cf2with only one value, based oncf1value:define rules for MandatoryOnTransition plugin that implies both
cf1andcf2:change status of a test ticket, selecting value 2 for
cf1cf2, as there is no possible values for this CF in that casetry to validate page => MandatoryOnTransition blocks from validating, saying that a value must be selected for
cf2