Skip to content

Commit 3897198

Browse files
cbrandtbuffalosunnavy
authored andcommitted
Remove the Iframe research tool config and pages
Browsers are becoming much more restrictive in loading content in Iframes and many sites have also added code to prevent loading in Iframes. None of the examples previously provided in the default RTIR configuration were still working.
1 parent 9bf1ce5 commit 3897198

4 files changed

Lines changed: 11 additions & 173 deletions

File tree

docs/UPGRADING-6.0

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,16 @@ component on the home page that refreshed the entire page.
3838
See the RT 6 upgrading documentation for details on the update to refresh
3939
features.
4040

41+
=item *
42+
43+
The Iframe option for adding research tools to the lookup pages in RTIR
44+
previously configured with C<$RTIRIframeResearchToolConfig> has been removed.
45+
Browsers are becoming much more restrictive when loading content in Iframes
46+
and many websites are also adding code to block them from being loaded in
47+
Iframes. In our testing, the default example configurations provided with
48+
RTIR no longer worked and we didn't find other replacements that would
49+
work by loading them in an Iframe.
50+
4151
=back
4252

4353
=cut

etc/RTIR_Config.pm

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -792,27 +792,7 @@ using the following mason components:
792792
793793
=cut
794794

795-
Set( @RTIRResearchTools, (qw(Traceroute Whois Iframe)));
796-
797-
=item C<$RTIRIframeResearchToolConfig>
798-
799-
One of the research tools available in RTIR allows you to
800-
configure a set of search URLs that incident handlers
801-
can use to open searches in IFRAMES.
802-
803-
Entries are keyed by integer in the order you'd like to see
804-
them in the dropdown on the research page. Each entry consists
805-
of a hashref containing "FriendlyName" and "URL". The URLs will
806-
be evaluated to replace __SearchTerm__ with the user's current
807-
search term.
808-
809-
=cut
810-
811-
Set($RTIRIframeResearchToolConfig, {
812-
1 => { FriendlyName => 'Google', URL => 'https://encrypted.google.com/search?q=__SearchTerm__' },
813-
2 => { FriendlyName => 'CVE', URL => 'http://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=__SearchTerm__'},
814-
3 => { FriendlyName => 'McAfee SiteAdvisor', URL => 'http://www.siteadvisor.com/sites/__SearchTerm__'}
815-
} );
795+
Set( @RTIRResearchTools, (qw(Traceroute Whois)));
816796

817797
=item C<$TracerouteCommand>
818798

html/RTIR/Tools/Elements/ToolFormIframe

Lines changed: 0 additions & 83 deletions
This file was deleted.

html/RTIR/Tools/Elements/ToolResultsIframe

Lines changed: 0 additions & 69 deletions
This file was deleted.

0 commit comments

Comments
 (0)