Skip to content

Commit 9bf1ce5

Browse files
cbrandtbuffalosunnavy
authored andcommitted
Make lookup buttons smaller to not overwhelm the page
Some content on tickets can have a large number of IPs or domains and even the "small" size bootstrap buttons are large and dominate the page. Convert them to a much smaller size and use the outline formatting to reduce the visual impact on the page.
1 parent 11b7260 commit 9bf1ce5

2 files changed

Lines changed: 17 additions & 10 deletions

File tree

html/Callbacks/RTIR/Elements/MakeClicky/Default

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ my %actions;
8282
# don't execute on non-rtir tickets or in SelfService
8383
return $super unless defined $args{type} and !$SelfService;
8484

85-
my $result = qq{ <a class="button btn btn-sm btn-primary" href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=host&q=".$escaped_host).qq{">}
85+
my $result = qq{ <a class="btn btn-outline-primary rtir-lookup-button" href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=host&q=".$escaped_host).qq{">}
8686
.loc('lookup "[_1]"', $host) .qq{</a>};
8787
return $super . qq{ <span class="clickylink">$result</span>};
8888
},
@@ -96,7 +96,7 @@ my %actions;
9696
# don't execute on non-rtir tickets or in SelfService
9797
return $super unless defined $args{type} and !$SelfService;
9898

99-
my $result = qq{ <a class="button btn btn-sm btn-primary" href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=host&q=".$escaped_host).qq{">}
99+
my $result = qq{ <a class="btn btn-outline-primary rtir-lookup-button" href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=host&q=".$escaped_host).qq{">}
100100
.loc('lookup "[_1]"', $host) .qq{</a>};
101101
return $super . qq{ <span class="clickylink">$result</span>};
102102
},
@@ -108,17 +108,17 @@ my %actions;
108108

109109
$args{host} ||= $args{value};
110110
my $escaped_host = $escaper->($args{host});
111-
my $result .= qq{ <a class="button btn btn-sm btn-primary" href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=ip&q=".$escaped_host).qq{">}
111+
my $result .= qq{ <a class="btn btn-outline-primary rtir-lookup-button" href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=ip&q=".$escaped_host).qq{">}
112112
.loc('Lookup IP') .q{</a>};
113113
if ( $args{incident} && !RT->Config->Get('RTIR_DisableCountermeasures') ) {
114-
$result .= qq{ <a class="button btn btn-sm btn-primary create_child_} . RT::IR->lifecycle_countermeasure . qq{" href="} .
114+
$result .= qq{ <a class="btn btn-outline-primary rtir-lookup-button create_child_} . RT::IR->lifecycle_countermeasure . qq{" href="} .
115115
RT::IR->HREFTo("Create.html?Incident=".$args{incident}."&Lifecycle=".RT::IR->lifecycle_countermeasure.qq{&IP-Value=$escaped_host})
116116
.qq{">Block</a>};
117117
}
118118
if ( $args{'object'} && $args{'object'}->id ) {
119119
my $cf = RT::IR::GetCustomField('IP');
120120
my $tid = $args{'object'}->id;
121-
$result .= qq{ <a class="button btn btn-sm btn-primary" href="}.
121+
$result .= qq{ <a class="btn btn-outline-primary rtir-lookup-button" href="}.
122122
RT::IR->HREFTo("Edit.html?id=".$tid
123123
.qq{&Object-RT::Ticket-$tid-CustomField-}. $cf->id .qq{-AddValue=$escaped_host}
124124
.q{&SaveChanges=1})
@@ -154,7 +154,7 @@ my %actions;
154154
my $email = $args{'value'}; $email =~ s/^<|>$//g;
155155
my $escaped_email = $escaper->($email);
156156

157-
my $result = qq{<a class="button btn btn-sm btn-primary" href="}.
157+
my $result = qq{<a class="btn btn-outline-primary rtir-lookup-button" href="}.
158158
RT::IR->HREFTo(qq{Tools/Lookup.html?$args{'lookup_params'}type=email&q=$escaped_email}). qq{">}
159159
.loc('lookup email') .q{</a>};
160160
if ( $args{'incident'} ) {
@@ -163,7 +163,7 @@ my %actions;
163163
if ( $r->uri =~ /Lookup.html$/ ) {
164164
$result .= qq{<div class="custom-control custom-checkbox d-inline-block"><input type="checkbox" class="custom-control-input" id="Requestorbox-$escaped_email" name="Requestorbox-$escaped_email" /> <label class="custom-control-label" for="Requestorbox-$escaped_email"></label></div>};
165165
}
166-
$result .= qq{ <a class="button btn btn-sm btn-primary" href="}.
166+
$result .= qq{ <a class="btn btn-outline-primary rtir-lookup-button" href="}.
167167
RT::IR->HREFTo( "Create.html"
168168
. qq{?Incident=$args{'incident'}}
169169
. qq{&Lifecycle=}.RT::IR->lifecycle_investigation
@@ -173,7 +173,7 @@ my %actions;
173173
}
174174
my $domain = (split /@/, $email, 2)[1];
175175
my $escaped_domain = $escaper->($domain);
176-
$result .= ' <a class="button btn btn-sm btn-primary" href="'. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{'lookup_params'}type=host&q=$escaped_domain}). '">'
176+
$result .= ' <a class="btn btn-outline-primary rtir-lookup-button" href="'. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{'lookup_params'}type=host&q=$escaped_domain}). '">'
177177
.loc('lookup "[_1]"', $domain) .'</a>';
178178
return $escaper->($args{'value'}) . qq{ <span class="clickylink">$result</span>};
179179
},
@@ -184,7 +184,7 @@ my %actions;
184184
return $escaper->($args{value}) unless defined $args{type} and !$SelfService;
185185

186186
$args{value} = $escaper->($args{value});
187-
my $result = qq{ <a class="button btn btn-sm btn-primary" href="}. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{lookup_params}type=handle&q=$args{value}}).qq{">}
187+
my $result = qq{ <a class="btn btn-outline-primary rtir-lookup-button" href="}. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{lookup_params}type=handle&q=$args{value}}).qq{">}
188188
.loc('lookup') .qq{</a>};
189189
return $args{value} . qq{ <span class="clickylink">$result</span>};
190190
},
@@ -195,7 +195,7 @@ my %actions;
195195
return $escaper->($args{value}) unless defined $args{type} and !$SelfService;
196196

197197
$args{value} = $escaper->($args{value});
198-
my $result = qq{ <a class="button btn btn-sm btn-primary" href="}. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{lookup_params}type=host&q=$args{value}}). qq{">}
198+
my $result = qq{ <a class="btn btn-outline-primary rtir-lookup-button" href="}. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{lookup_params}type=host&q=$args{value}}). qq{">}
199199
.loc('lookup host') .qq{</a>};
200200
return $args{value} . qq{ <span class="clickylink">$result</span>};
201201
},

static/css/rtir-styles.css

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,3 +202,10 @@ body.rtir .titlebox.external-feeds tr.evenline+.evenline .collection-as-table {
202202
.rtir.darkmode .clickylink a.button:hover {
203203
background: #3A474D !important;
204204
}
205+
206+
/* Make lookup buttons small since on some screens many can be shown */
207+
a.rtir-lookup-button {
208+
--bs-btn-padding-y: .2rem;
209+
--bs-btn-padding-x: .3rem;
210+
--bs-btn-font-size: .6rem;
211+
}

0 commit comments

Comments
 (0)