Check against expected RTIRSearchEnabled value

craigkai · craigkai · commit fef3d25d21ae · 2025-11-14T14:07:08.000-05:00
Previously we only checked for a truthy value when deciding if
RTIRSearchEnabled was true. We should explicitly check for the
string value 'Yes' so that other values like 'No' do not result
in a false positive.
diff --git a/html/Callbacks/RTIR/Elements/ShowSearch/ModifySearch b/html/Callbacks/RTIR/Elements/ShowSearch/ModifySearch
@@ -56,7 +56,7 @@ if ( $ARGS{'SavedSearch'} ) {
 }
 
 return
-    unless $m->request_comp->path =~ m{^/RTIR/} || ( $search && $search->GetOption('RTIRSearchEnabled') );
+    unless $m->request_comp->path =~ m{^/RTIR/} || ( $search && ($search->GetOption('RTIRSearchEnabled') // '') eq 'Yes' );
 
 # HTMX search requests will have the constituency added as a query param
 if ( my $c = $ARGS{'ConstituencyFilter'} ) {

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ if ( $ARGS{'SavedSearch'} ) {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`return`
`59`		`- unless $m->request_comp->path =~ m{^/RTIR/} \|\| ( $search && $search->GetOption('RTIRSearchEnabled') );`
	`59`	`+ unless $m->request_comp->path =~ m{^/RTIR/} \|\| ( $search && ($search->GetOption('RTIRSearchEnabled') // '') eq 'Yes' );`
`60`	`60`
`61`	`61`	`# HTMX search requests will have the constituency added as a query param`
`62`	`62`	`if ( my $c = $ARGS{'ConstituencyFilter'} ) {`