Skip to content

Commit 138ecef

Browse files
committed
feat(resources): fix review bugs
1 parent 48f5a94 commit 138ecef

6 files changed

Lines changed: 36 additions & 39 deletions

File tree

packages/configurator/src/source-select-configurator/SourceSelectConfigurator.vue

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
v-model="isShow"
77
:visible-arrow="false"
88
:popper-class="['option-popper', 'fixed-left']"
9-
height="844"
109
>
1110
<div class="source-wrap">
1211
<div class="source-title">
@@ -46,7 +45,7 @@
4645
</div>
4746
<div class="source-list">
4847
<div v-for="(item, index) in sourceList" :key="item.id" class="source-item">
49-
<img :src="item.thumbnailUrl ?? item.resourceUrl" />
48+
<img :src="item.thumbnailUrl || item.resourceUrl" />
5049
<tiny-radio
5150
v-model="selectedSourceIndex"
5251
@change="selectSource(index)"
@@ -77,15 +76,7 @@
7776
<script lang="ts">
7877
import { ref, watch } from 'vue'
7978
import type { Component } from 'vue'
80-
import {
81-
Popover as TinyPopover,
82-
Button as TinyButton,
83-
Input as TinyInput,
84-
Search as TinySearch,
85-
Select as TinySelect,
86-
Divider as TinyDivider,
87-
Radio as TinyRadio
88-
} from '@opentiny/vue'
79+
import { Popover as TinyPopover, Button as TinyButton, Input, Search, Select, Divider, Radio } from '@opentiny/vue'
8980
import { iconClose, iconSearch } from '@opentiny/vue-icon'
9081
import { SearchEmpty } from '@opentiny/tiny-engine-common'
9182
import { useNotify } from '@opentiny/tiny-engine-meta-register'
@@ -105,12 +96,12 @@ export default {
10596
components: {
10697
TinyPopover: TinyPopover as Component,
10798
TinyButton: TinyButton as Component,
108-
TinyInput: TinyInput as Component,
109-
TinySearch: TinySearch as Component,
110-
TinySelect: TinySelect as Component,
111-
TinyDivider: TinyDivider as Component,
112-
TinyRadio: TinyRadio as Component,
113-
SearchEmpty: SearchEmpty as Component,
99+
TinyInput: Input,
100+
TinySearch: Search,
101+
TinySelect: Select,
102+
TinyDivider: Divider,
103+
TinyRadio: Radio,
104+
SearchEmpty,
114105
TinyIconClose: iconClose(),
115106
TinyIconSearch: iconSearch()
116107
},
@@ -181,7 +172,9 @@ export default {
181172
watch(
182173
() => searchWords.value,
183174
() => {
184-
sourceList.value = sourceOriginList.value.filter((item) => item.name.includes(searchWords.value))
175+
sourceList.value = sourceOriginList.value.filter((item) =>
176+
item.name.toLowerCase().includes(searchWords.value.toLowerCase())
177+
)
185178
}
186179
)
187180

packages/configurator/src/source-select-configurator/http.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export const fetchResourceListByGroupId = (resourceGroupId: number) =>
1919
getMetaApi(META_SERVICE.Http).get(`${baseUrl}/resource/find/${resourceGroupId}`)
2020

2121
// 资源管理 -- 根据appId查询资源分组列表
22-
export const fetchResourceGroupByAppId = (appId: number) =>
22+
export const fetchResourceGroupByAppId = (appId?: number) =>
2323
getMetaApi(META_SERVICE.Http).get(
2424
`${baseUrl}/resource-group/${appId || getMetaApi(META_SERVICE.GlobalService).getBaseInfo().id}`
2525
)

packages/plugins/resource/src/Main.vue

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,17 +35,20 @@
3535
<search-empty :isShow="!resourceList?.length" />
3636
</template>
3737
</plugin-panel>
38-
<resource-setting @create-group="refreshCategory"></resource-setting>
38+
<resource-setting @refreshCategory="refreshCategory"></resource-setting>
3939
<resource-list></resource-list>
4040
</div>
4141
</template>
42-
<script>
42+
<script lang="ts">
43+
/* metaService: engine.plugins.resource.Main */
4344
import { ref, reactive, provide, onMounted } from 'vue'
4445
import { useLayout, useNotify } from '@opentiny/tiny-engine-meta-register'
4546
import { PluginPanel, SvgButton, SearchEmpty } from '@opentiny/tiny-engine-common'
4647
import ResourceSetting, { openResourceSettingPanel, closeResourceSettingPanel } from './ResourceSetting.vue'
4748
import ResourceList, { openResourceListPanel, closeResourceListPanel } from './ResourceList.vue'
4849
import { fetchResourceGroupByAppId } from './js/http'
50+
51+
/* metaComponent: engine.plugins.resource */
4952
export default {
5053
components: {
5154
PluginPanel,

packages/plugins/resource/src/ResourceList.vue

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
name="tiny-checkbox"
3636
@change="selectSource($event, item)"
3737
></tiny-checkbox>
38-
<div class="source-action">
38+
<div class="source-action" v-if="!enableBatchAction">
3939
<tiny-popover placement="bottom" :visible-arrow="false" :offset="-18" trigger="hover">
4040
<div class="actions">
4141
<tiny-popover
@@ -141,17 +141,19 @@
141141
</tiny-dialog-box>
142142
</teleport>
143143
</template>
144-
<script>
144+
<script lang="ts">
145+
/* metaService: engine.plugins.resource.ResourceList */
145146
import { ref, reactive, computed, watch } from 'vue'
147+
import type { Component } from 'vue'
146148
import useClipboard from 'vue-clipboard3'
147149
import {
148-
Button,
150+
Button as TinyButton,
149151
Divider,
150152
Grid,
151153
GridColumn,
152154
Input,
153-
Checkbox,
154-
Popover,
155+
Checkbox as TinyCheckbox,
156+
Popover as TinyPopover,
155157
DialogBox,
156158
Alert,
157159
FileUpload
@@ -184,13 +186,13 @@ export default {
184186
components: {
185187
PluginSetting,
186188
SvgButton,
187-
TinyButton: Button,
189+
TinyButton: TinyButton as Component,
188190
TinyDivider: Divider,
189191
TinyGrid: Grid,
190192
TinyGridColumn: GridColumn,
191193
TinyInput: Input,
192-
TinyCheckbox: Checkbox,
193-
TinyPopover: Popover,
194+
TinyCheckbox: TinyCheckbox as Component,
195+
TinyPopover: TinyPopover as Component,
194196
TinyDialogBox: DialogBox,
195197
TinyAlert: Alert,
196198
TinyFileUpload: FileUpload,
@@ -224,7 +226,7 @@ export default {
224226
type: 'string',
225227
validator: ({ row }, value) => {
226228
return new Promise((resolve, reject) => {
227-
const regex = /^[a-zA-Z0-9_\-=+(){}[\]\u4e00-\u9fa5]+\.(png|jpg|jpeg|svg|PNG|JPG|JPEG|SVG)$/i
229+
const regex = /^[a-zA-Z0-9_\-=+(){}[\]\u4e00-\u9fa5]+\.(png|jpg|jpeg|svg|PNG|JPG|JPEG|SVG)$/
228230
if (!regex.test(value)) {
229231
reject(new Error('资源名称格式错误'))
230232
} else if (addSourceData.value.find((item) => item._RID !== row._RID && item.name === value)) {

packages/plugins/resource/src/ResourceSetting.vue

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,11 @@
3232
</template>
3333
</plugin-setting>
3434
</template>
35-
<script>
35+
<script lang="ts">
36+
/* metaService: engine.plugins.resource.ResourceSetting */
3637
import { ref, reactive, computed } from 'vue'
37-
import { Button, Collapse, CollapseItem, Form, FormItem, Input } from '@opentiny/vue'
38+
import type { Component } from 'vue'
39+
import { Button as TinyButton, Collapse, CollapseItem, Form, FormItem, Input } from '@opentiny/vue'
3840
import { useLayout, useNotify } from '@opentiny/tiny-engine-meta-register'
3941
import { PluginSetting, ButtonGroup, SvgButton } from '@opentiny/tiny-engine-common'
4042
import { createResourceGroup, updateResourceGroup } from './js/http'
@@ -65,7 +67,7 @@ export default {
6567
components: {
6668
PluginSetting,
6769
SvgButton,
68-
TinyButton: Button,
70+
TinyButton: TinyButton as Component,
6971
TinyCollapse: Collapse,
7072
TinyCollapseItem: CollapseItem,
7173
TinyFormItem: FormItem,
@@ -74,7 +76,7 @@ export default {
7476
ButtonGroup
7577
},
7678
props: {},
77-
emits: ['create-group'],
79+
emits: ['refreshCategory'],
7880
setup(props, { emit }) {
7981
const { PLUGIN_NAME, getPluginByLayout } = useLayout()
8082
const align = computed(() => getPluginByLayout(PLUGIN_NAME.Resource))
@@ -108,7 +110,7 @@ export default {
108110
if (state.data.id) {
109111
updateResourceGroup(state.data.id, { name: state.data.name, description: state.data.description })
110112
.then(() => {
111-
emit('create-group')
113+
emit('refreshCategory')
112114
closeResourceSettingPanel()
113115
useNotify({ message: '修改资源分组成功', type: 'success' })
114116
})
@@ -118,7 +120,7 @@ export default {
118120
} else {
119121
createResourceGroup(state.data)
120122
.then(() => {
121-
emit('create-group')
123+
emit('refreshCategory')
122124
closeResourceSettingPanel()
123125
useNotify({ message: '添加资源分组成功', type: 'success' })
124126
})

packages/plugins/resource/src/js/http.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ export const deleteResource = (id: number) => getMetaApi(META_SERVICE.Http).get(
4646
// 资源管理 -- 获取资源详情
4747
export const fetchResourceDetail = (id: number) => getMetaApi(META_SERVICE.Http).get(`${baseUrl}/resource/detail/${id}`)
4848

49-
// 资源管理 -- 查询资源分组列表
50-
export const fetchResourceGroupList = () => getMetaApi(META_SERVICE.Http).get(`${baseUrl}/resource-group/list`)
51-
5249
// 资源管理 -- 根据appId查询资源分组列表
5350
export const fetchResourceGroupByAppId = () =>
5451
getMetaApi(META_SERVICE.Http).get(

0 commit comments

Comments
 (0)