Draft
Conversation
Notably, zola has produced their own code highlighting solution that in the future causes us to need to write our custom .css syntax theme as a vscode theme instead. However, as far as I can tell, this is not possible until zola releases a new version. The current state is that the CSS overrides we use aren't applied as they were previously when using zola's new giallo. - zola built a replacement for syntect called giallo: getzola/zola#2758 - There are CSS fixes to code style generation that seem relevant but will fully break any attempt at the css class based highlighting that we have now: getzola/giallo#56 > The current CSS generation in giallo is broken: getzola/giallo#56 will be included in the next Zola release. > > [keats](getzola/zola#3075 (comment)) - We will need to write our theme as a vscode theme to regain styling. I haven't explored actually writing this theme file yet so don't know if there will be regressions or opportunities for enhancements.
Contributor
Author
|
I'm also going to mention @Keats , since they commented on the relevant #2325 , just in case they're interested in the topic. Our next steps are to explore writing the vscode theme file to regain our custom syntax highlighting. however, the syntax highlighting is the only blocker we have for upgrading zola. There are no other issues as far as I can tell. |
Contributor
Shouldn't be. 0.23 will have the biggest changes for the template engine but it's not out yet. Since it will contain the fix for giallo CSS though, it might be better to wait for it |
alice-i-cecile
added
C-Webdev
S-Blocked
X-Contentious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This is currently not mergable as the new zola syntax highlighting means our custom CSS overrides are not applied.
side-by-side of ron/rust/wgsl examples on the site
Notably, zola has produced their own code highlighting solution that in the future causes us to need to write our custom .css syntax theme as a vscode theme instead. However, as far as I can tell, this is not possible until zola releases a new version. The current state is that the CSS overrides we use aren't applied as they were previously when using zola's new giallo.