Render Architecture Overview & Pipelined Rendering Book Pages#2469
Conversation
Based-A
requested review from
IceSentry,
JMS55,
alice-i-cecile and
fallible-algebra
cookie1170
left a comment
cookie1170
left a comment
There was a problem hiding this comment.
i have a few small nits on the wording, but nothing major
Based-A
changed the title
Co-authored-by: IceSentry <IceSentry@users.noreply.github.com>
|
|
||
| Since the Render `App` abides by the ECS principles, we can leverage systems to perform the actual task of rendering. | ||
| Each system that accesses the [`RenderContext`] system parameter can be used to create the commands that are sent to the GPU to render the game. | ||
| Using systems allows us to structure the execution of each system with a [`Schedule`], either those provided by Bevy by default ([`Core2d`] and [`Core3d`]), or by creating a custom render schedule. |
There was a problem hiding this comment.
Might be worth saying here that Bevy is camera driven - can Camera2d/Camera3d component drives a separate execution of the Core2d/Core3d schedule
There was a problem hiding this comment.
I don't think it fits nicely in this particular section, but it's making me think that it's a better idea to put a Camera Driven Rendering page before the Render Pipelines page. I do see the benefit of mentioning it, but at the same time I feel like it distracts from the flow of the section.
There was a problem hiding this comment.
Coming back around to this, same thing as I was saying above to Alice. Don't want to get too into Camera-driven Rendering without the dedicated page to link out to. Could we leave it as is and then include a bit about it once we have the Camera Driven Rendering page?
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
took a read and this looks like a good foundation to expand upon
alice-i-cecile
added
S-Ready-For-Final-Review
|
@Based-A Can you please go through and resolve conversations that have been addressed? |
|
Yeah sorry, forgot to do that when I as going through. Most of it should be addressed, but the comments that aren't resolved are for sections that were cut from the pages. I'll do another quick pass tomorrow to make sure everything is good since it's been a minute, but I normally mark the things I've addressed with the 👍 reaction, so going off of that I think everything should be addressed. |
Co-authored-by: Daniel Skates <zeophlite@gmail.com>
|
@alice-i-cecile Apologies for the delay, got wrapped up with a lot of work. Went back through all of the comments and double checked, I think I've gotten everything that can be added in this PR and then made some notes about future pages. There's just two related comments about Camera Driven Rendering that I've unresolved, but I'm waiting to see what needs to happen with them. |
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Good! No glaring factual issues, nice writing, solid organization. Let's merge this.
7 participants
First attempt at an overview page, hitting only the big topics and trying not to dive into too much detail. Let me know any critiques or corrections, more than happy to continue iterating if needed.