Commit 2e66bb9
authored
conditionally disable tests on miri for taking way too long (#23677)
# Objective
The PR CI takes a long time, particularly because of miri. maybe disable
some tests on miri?
related to #20818 (partitioning seems to lead to about 20 6-8minute
slices if running on ubuntu, but miri also doesn't have a cached build,
I'm not sure how much that could help; 20x 6 minutes is like a lot
compared to 1x 25-30 minutes which I think was the reason @mockersf
stopped pursuing that direction)
## Solution
I've found 3 tests which take quite a bit longer than the rest. These
are pretty low hanging fruits for reducing the time miri takes to test,
HOWEVER I'm not sure if these tests benefit from miri (especially the
toctou one) and should definitely run on miri.
Edit: looks like this doesn't result in any meaningful difference
because now the windows build is the bottleneck1 parent c6bb950 commit 2e66bb9
3 files changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2064 | 2064 | | |
2065 | 2065 | | |
2066 | 2066 | | |
| 2067 | + | |
2067 | 2068 | | |
2068 | 2069 | | |
2069 | 2070 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3048 | 3048 | | |
3049 | 3049 | | |
3050 | 3050 | | |
| 3051 | + | |
3051 | 3052 | | |
3052 | 3053 | | |
3053 | 3054 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
| 160 | + | |
160 | 161 | | |
161 | 162 | | |
162 | 163 | | |
| |||
0 commit comments