Commit 3968184
authored
Make sure #[track_caller] in EntityCommands::insert_if_neq works as intended (#23986)
intended
# Objective
Fixes #23962
## Solution
As suggested in the issue: "go back to insert_with_caller so that we can
call MaybeLocation::caller() outside of the closure and then pass it
through explicitly".
## Testing
Added a unit test and made sure it fails without the fix.1 parent e9e15e5 commit 3968184
1 file changed
Lines changed: 51 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| |||
1485 | 1486 | | |
1486 | 1487 | | |
1487 | 1488 | | |
| 1489 | + | |
| 1490 | + | |
1488 | 1491 | | |
1489 | 1492 | | |
1490 | 1493 | | |
1491 | 1494 | | |
1492 | 1495 | | |
1493 | | - | |
| 1496 | + | |
| 1497 | + | |
| 1498 | + | |
| 1499 | + | |
| 1500 | + | |
| 1501 | + | |
| 1502 | + | |
1494 | 1503 | | |
1495 | 1504 | | |
1496 | 1505 | | |
| |||
2739 | 2748 | | |
2740 | 2749 | | |
2741 | 2750 | | |
| 2751 | + | |
| 2752 | + | |
| 2753 | + | |
| 2754 | + | |
| 2755 | + | |
| 2756 | + | |
| 2757 | + | |
| 2758 | + | |
| 2759 | + | |
| 2760 | + | |
| 2761 | + | |
| 2762 | + | |
| 2763 | + | |
| 2764 | + | |
| 2765 | + | |
| 2766 | + | |
| 2767 | + | |
| 2768 | + | |
| 2769 | + | |
| 2770 | + | |
| 2771 | + | |
| 2772 | + | |
| 2773 | + | |
| 2774 | + | |
| 2775 | + | |
| 2776 | + | |
| 2777 | + | |
| 2778 | + | |
| 2779 | + | |
| 2780 | + | |
| 2781 | + | |
| 2782 | + | |
| 2783 | + | |
| 2784 | + | |
| 2785 | + | |
| 2786 | + | |
| 2787 | + | |
| 2788 | + | |
| 2789 | + | |
| 2790 | + | |
| 2791 | + | |
2742 | 2792 | | |
2743 | 2793 | | |
2744 | 2794 | | |
| |||
0 commit comments