Skip to content

Commit 6e93c2e

Browse files
Sigma-devSigma
andauthored
fix: add missing png feature to bevy_feathers feature (#24727)
# Objective If `bevy_feathers` is used without default features, then the built-in feathers icons arn't displayed with no warnings. ## Solution Add `png` feature flag to `bevy_feathers` since it has all it's widget icons as pngs. An alternate solution would be to add a warning instead somehow. ## Testing Add a simple scene with `FeathersDisclosureToggle` (or any other icon using widget) and test it with no default features (but still necessary render features): Pre-fix there will be nothing dispalyed but it will work fine post-fix. (Example command for linux) ``` cargo run --no-default-features --features "bevy_winit,bevy_ui_render,scene,default_font,x11,bevy_state,bevy_asset,bevy_log,multi_threaded,async_executor,reflect_auto_register,bevy_feathers" ``` Fixes #24682 Co-authored-by: Sigma <antonin.programming@gmail.com>
1 parent f4d3026 commit 6e93c2e

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

crates/bevy_internal/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,8 @@ bevy_sprite_render = [
270270
"bevy_gizmos_render?/bevy_sprite_render",
271271
]
272272
bevy_ui_render = ["dep:bevy_ui_render", "bevy_sprite_render", "bevy_ui"]
273+
# Feathers ships its built-in icons as PNGs, so enable the PNG feature
274+
bevy_feathers = ["dep:bevy_feathers", "png"]
273275
bevy_solari = ["dep:bevy_solari", "bevy_pbr"]
274276
bevy_gizmos = ["dep:bevy_gizmos", "bevy_camera", "bevy_light?/bevy_gizmos"]
275277
bevy_gizmos_render = ["dep:bevy_gizmos_render", "bevy_gizmos"]

0 commit comments

Comments
 (0)