replace AccessScope with AsAccess

Author: ItsDoot

crates/bevy_ecs/src/entity/clone_entities.rs

@@ -635,7 +635,7 @@ impl EntityCloner {
                 // - `component` is from `source_entity`'s archetype
                 let source_component_ptr = unsafe {
                     source_entity
-                        .get_by_id(&All, component)
+                        .get_by_id(All, component)
                         .debug_checked_unwrap()
                 };
 

crates/bevy_ecs/src/observer/runner.rs

@@ -46,7 +46,7 @@ pub(super) unsafe fn observer_system_runner<E: Event, B: Bundle, S: ObserverSyst
     // SAFETY: Observer was triggered so must have an `Observer`
     let mut state = unsafe {
         observer_cell
-            .get_mut::<Observer>(&All)
+            .get_mut::<Observer>(All)
             .debug_checked_unwrap()
     };
 

crates/bevy_ecs/src/reflect/component.rs

@@ -383,7 +383,7 @@ impl<C: Component + Reflect + TypePath> FromType<C> for ReflectComponent {
                 // SAFETY: reflect_unchecked_mut is an unsafe function pointer used by
                 // `reflect_unchecked_mut` which must be called with an UnsafeEntityCell with access to the component `C` on the `entity`
                 // guard ensures `C` is a mutable component
-                let c = unsafe { entity.get_mut_assume_mutable::<C>(&All) };
+                let c = unsafe { entity.get_mut_assume_mutable::<C>(All) };
                 c.map(|c| c.map_unchanged(|value| value as &mut dyn Reflect))
             },
             register_component: |world: &mut World| -> ComponentId {

crates/bevy_ecs/src/world/entity_access/access_scope.rs

@@ -8,7 +8,7 @@ impl<'w> EntityRef<'w, All> {
     /// all components.
     pub fn into_filtered(self) -> FilteredEntityRef<'w, 'static> {
         // SAFETY:
-        // - `Access:new_read_all` equals the read permissions of `self`'s `All` scope.
+        // - `Access:new_read_all` equals the read permissions of `self`'s `All` access.
         unsafe { EntityRef::new(self.cell, Filtered(const { &Access::new_read_all() })) }
     }
 
@@ -54,7 +54,7 @@ impl<'w> EntityMut<'w, All> {
     #[inline]
     pub fn into_filtered(self) -> FilteredEntityMut<'w, 'static> {
         // SAFETY:
-        // - `Access::new_write_all` equals the read and write permissions of `entity`'s `All` scope.
+        // - `Access::new_write_all` equals the read and write permissions of `entity`'s `All` access.
         // - Consuming `self` ensures there are no other accesses.
         unsafe { EntityMut::new(self.cell, Filtered(const { &Access::new_write_all() })) }
     }