Remove ExtractedView::hdr, add ExtractedView::texture_format, move compositing_space to ExtractedCamera by atlv24 · Pull Request #23734 · bevyengine/bevy

atlv24 · 2026-04-09T06:17:38Z

Objective

Clean up our texture format handling.
Fix Hdr required to get rendertarget to respect TextureFormat #23732
Get us closer to HDR Display Output #22563
It makes no sense for views to talk about being hdr or not. They have a texture format, that's it. What does HDR shadows even mean lol
Same for compositing_space

Solution

Remove ExtractedView::hdr
Add ExtractedView::texture_format
Move ExtractedView::compositing_space to ExtractedCamera::compositing_space
Add texture_format to a bunch of specialization keys instead of hdr bool
Convert VolumetricFogPipelineKey to not use flags and just use bool and texture format
Remove BevyDefault TextureFormat
Remove ViewTarget TEXTURE_FORMAT_HDR

Testing

Pretty extensively test at this point

This has a migration guide.

github-actions · 2026-04-09T06:18:27Z

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

jasmine-nominal · 2026-04-09T15:56:54Z

Can you add docs to ExtractedCamera/View clarifying the differences between them? (view can be any sort of rendering thing e.g. a shadow map, camera is stuff relevant to an actual camera)

IceSentry

I really like the direction of this PR, bit +1 from me once CI is passing.

tychedelia

Ty, this is a helpful step towards some other goals I have here. I'm wondering for a few of these passes where you switched to camera.hdr, is there a strong reason not to have them use the view target texture?

mate-h · 2026-04-10T08:00:18Z

I like the direction you're proposing! very nice. Extracted views really shouldn't care about hdr or compositing space or not, cameras should. I did a bunch of research and testing for this PR and I tried fixing the 2d hdr bloom, 3d scene examples and also created a compositing space example. While trying not to reintroduce any of the antipatterns being cleaned up in this PR. atlv24#5

beicause · 2026-04-10T08:17:00Z

I hope we could put all webgpu renderable && blendable formats into the mesh pipeline key to reduce collisions with #22637. But I'm not against the current either.

Texture formats, camera extraction

atlv24 · 2026-04-11T08:02:21Z

@beicause I have incorporated some of your changes with attribute. I'd appreciate a review, thanks!

Co-authored-by: Luo Zhihao <luo_zhihao@outlook.com>

Co-authored-by: atlv <email@atlasdostal.com>

mate-h

Re-reviewed! I don't have any blocking comments, I also tested again with my compositing space example looks good.

Co-authored-by: Máté Homolya <mate.homolya@gmail.com>

salixsalicaceae · 2026-04-13T12:05:50Z

Confirmed to fix #23732

…rmat

atlv24 · 2026-04-13T19:24:48Z

This PR is good to merge, example runner passed (only fail is a flake that is flakey on main too)

…mpositing_space to ExtractedCamera (bevyengine#23734) # Objective - Clean up our texture format handling. - Fix bevyengine#23732 - Get us closer to bevyengine#22563 - It makes no sense for views to talk about being hdr or not. They have a texture format, that's it. What does HDR shadows even mean lol - Same for compositing_space ## Solution - Remove ExtractedView::hdr - Add ExtractedView::texture_format - Move ExtractedView::compositing_space to ExtractedCamera::compositing_space - Add texture_format to a bunch of specialization keys instead of hdr bool - Convert VolumetricFogPipelineKey to not use flags and just use bool and texture format - Remove BevyDefault TextureFormat - Remove ViewTarget TEXTURE_FORMAT_HDR ## Testing - Pretty extensively test at this point This has a migration guide. --------- Co-authored-by: Willow Black <wmcblack@gmail.com> Co-authored-by: Máté Homolya <mate.homolya@gmail.com> Co-authored-by: Luo Zhihao <luo_zhihao@outlook.com> Co-authored-by: IceSentry <IceSentry@users.noreply.github.com>

Remove ExtractedView::hdr and compositing_space, add texture_format

3279b48

atlv24 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 9, 2026

github-project-automation bot moved this to Needs SME Triage in Rendering Apr 9, 2026

github-project-automation bot added this to Rendering Apr 9, 2026

atlv24 requested review from mate-h and tychedelia April 9, 2026 06:18

atlv24 requested review from aevyrie, pcwalton and salixsalicaceae April 9, 2026 06:18

salixsalicaceae and others added 4 commits April 9, 2026 01:14

Fix mesh2d_manual example

15a78c5

fix startup crash

f78767c

Fix infinitegrid

8329159

Fix mesh2d_manual camera example fix

2a08f7a

IceSentry reviewed Apr 9, 2026

View reviewed changes

Comment thread crates/bevy_pbr/src/volumetric_fog/render.rs Outdated

IceSentry reviewed Apr 9, 2026

View reviewed changes

tychedelia approved these changes Apr 9, 2026

View reviewed changes

Comment thread crates/bevy_pbr/src/render/mesh.rs Outdated

Texture formats, camera extraction

83e7c45

Merge pull request #5 from mate-h/m/main-pass-texture-format

93047ce

Texture formats, camera extraction

mate-h approved these changes Apr 11, 2026

View reviewed changes

Add more bits to MeshPipelineKey for TextureFormat

9df57ec

Co-authored-by: Luo Zhihao <luo_zhihao@outlook.com>

atlv24 force-pushed the ad/view-texture-format branch from 136138c to 9df57ec Compare April 11, 2026 08:13

docs

9631afa

atlv24 commented Apr 12, 2026

View reviewed changes

Comment thread _release-content/migration-guides/camera-textureformats.md

Apply suggestions from code review

a45c24d

Co-authored-by: atlv <email@atlasdostal.com>

atlv24 commented Apr 12, 2026

View reviewed changes

Comment thread _release-content/migration-guides/camera-textureformats.md Outdated

Apply suggestion from @atlv24

282eb4e

mate-h approved these changes Apr 13, 2026

View reviewed changes

Comment thread crates/bevy_core_pipeline/src/fullscreen_material.rs Outdated

Comment thread crates/bevy_render/src/view/mod.rs Outdated

Comment thread crates/bevy_render/src/view/mod.rs Outdated

atlv24 and others added 2 commits April 12, 2026 17:58

Merge branch 'main' into ad/view-texture-format

27b305a

Update crates/bevy_render/src/view/mod.rs

65f2462

Co-authored-by: Máté Homolya <mate.homolya@gmail.com>

atlv24 commented Apr 13, 2026

View reviewed changes

Comment thread crates/bevy_image/src/image.rs Outdated

atlv24 and others added 4 commits April 12, 2026 17:59

Apply suggestion from @atlv24

64bd3f6

Don't use Bgra8UnormSrgb main texture when rendering to screen

e455be1

Specialize fullscreen material pipeline

31e1832

target_fmt

ffdbd42

salixsalicaceae approved these changes Apr 13, 2026

View reviewed changes

ci

e8a40a7

atlv24 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 13, 2026

atlv24 added 2 commits April 13, 2026 08:19

Merge remote-tracking branch 'beicause/bgra8' into ad/view-texture-fo…

baea33b

…rmat

doc fixes, renames

865ce0b

github-actions bot mentioned this pull request Apr 13, 2026

23734 bevyengine/bevy-example-runner#232

Closed

atlv24 commented Apr 13, 2026

View reviewed changes

Comment thread crates/bevy_render/src/view/mod.rs Outdated

Apply suggestion from @atlv24

905a7a5

beicause approved these changes Apr 13, 2026

View reviewed changes

atlv24 added this to the 0.19 milestone Apr 13, 2026

alice-i-cecile added this pull request to the merge queue Apr 13, 2026

Merged via the queue into bevyengine:main with commit 082c44e Apr 13, 2026
38 checks passed

github-project-automation bot moved this from Needs SME Triage to Done in Rendering Apr 13, 2026

Uh oh!

Conversation

atlv24 commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Solution

Testing

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

jasmine-nominal commented Apr 9, 2026

Uh oh!

Uh oh!

IceSentry left a comment

Choose a reason for hiding this comment

Uh oh!

tychedelia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mate-h commented Apr 10, 2026

Uh oh!

beicause commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

atlv24 commented Apr 11, 2026

Uh oh!

Uh oh!

Uh oh!

mate-h left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

salixsalicaceae commented Apr 13, 2026

Uh oh!

Uh oh!

atlv24 commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

atlv24 commented Apr 9, 2026 •

edited

Loading

beicause commented Apr 10, 2026 •

edited

Loading