Skip to content

Add a rectangular light to the 3d testbed Light scene#24025

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
kfc35:testbed_3d_rect_light
Apr 29, 2026
Merged

Add a rectangular light to the 3d testbed Light scene#24025
alice-i-cecile merged 1 commit intobevyengine:mainfrom
kfc35:testbed_3d_rect_light

Conversation

@kfc35
Copy link
Copy Markdown
Contributor

@kfc35 kfc35 commented Apr 29, 2026

Objective

  • Regression test for broken Rect Lights

Solution

  • Add a rectangular light to testbed/3d

Testing

Before (w/o rect light)
Screenshot 2026-04-28 at 11 28 16 PM

After (w/ rect light - it’s behind the cube)
Screenshot 2026-04-28 at 11 25 33 PM

@kfc35 kfc35 added A-Rendering Drawing game state to the screen M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered labels Apr 29, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Apr 29, 2026
@kfc35 kfc35 added C-Testing A change that impacts how we test Bevy or how users test their apps D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 29, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 29, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 29, 2026
Merged via the queue into bevyengine:main with commit 0e49f63 Apr 29, 2026
51 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering Apr 29, 2026
tychedelia pushed a commit to processing/bevy that referenced this pull request Apr 30, 2026
# Objective

- Regression test for broken Rect Lights

## Solution

- Add a rectangular light to testbed/3d

## Testing

- `cargo run --example testbed_3d` - I can see the new light (well,
after bevyengine#24024 is merged hehe)

Before (w/o rect light)
<img width="1271" height="747" alt="Screenshot 2026-04-28 at 11 28
16 PM"
src="https://github.com/user-attachments/assets/aa6b6258-e80d-4a98-861c-bcad6e8db541"
/>

After (w/ rect light - it’s behind the cube)
<img width="1271" height="750" alt="Screenshot 2026-04-28 at 11 25
33 PM"
src="https://github.com/user-attachments/assets/877013f0-843a-43f2-9dbd-96f2fa37d8e2"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Testing A change that impacts how we test Bevy or how users test their apps D-Trivial Nice and easy! A great choice to get started with Bevy M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants