Add SystemIdTemplate to allow one-shot system in bsn!#24026
Draft
hxYuki wants to merge 5 commits intobevyengine:mainfrom
Draft
Add SystemIdTemplate to allow one-shot system in bsn!#24026hxYuki wants to merge 5 commits intobevyengine:mainfrom
SystemIdTemplate to allow one-shot system in bsn!#24026hxYuki wants to merge 5 commits intobevyengine:mainfrom
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
Contributor
Author
|
Not sure where to place these codes. I've searched |
hxYuki
commented
Apr 29, 2026
|
|
||
| impl Default for SystemIdTemplate { | ||
| fn default() -> Self { | ||
| Self::BoxedSystem(Arc::new(Mutex::new(Some(Box::new(IntoSystem::into_system(|| {})))))) |
Contributor
Author
There was a problem hiding this comment.
What should be the default value for a SystemId?
SkiFire13
reviewed
Apr 29, 2026
SkiFire13
reviewed
Apr 29, 2026
SkiFire13
reviewed
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
SystemIdTemplateFromTemplateforSystemIdsystem_value<M>to convert a system toSystemIdTemplateTesting
3d_scene.Showcase