Skip to content

Fix(bg motion vectors): gate BackgroundMotionVectorsPlugin pipelines to DownlevelFlags(INDEPENDENT_BLEND) #24067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kfc35 wants to merge 3 commits into
base: main
Choose a base branch
from
+29 −5
Open

Fix(bg motion vectors): gate BackgroundMotionVectorsPlugin pipelines to DownlevelFlags(INDEPENDENT_BLEND) #24067

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71bf772
fix(bg motion vectors): gate setting write_mask to `DownlevelFlags(IN…
kfc35 May 2, 2026
81bf1dd
fix: disable bg motion vector pipeline if lacking downlevel flag
kfc35 May 2, 2026
66cdde6
fix: move init of `PreviousViewUniforms` before check
kfc35 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions crates/bevy_core_pipeline/src/prepass/background_motion_vectors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,17 @@ use bevy_ecs::{
schedule::IntoScheduleConfigs,
system::{lifetimeless::Read, Commands, Query, Res, ResMut},
};
use bevy_log::warn;
use bevy_reflect::{std_traits::ReflectDefault, Reflect};
use bevy_render::{
extract_component::{ExtractComponent, ExtractComponentPlugin},
render_resource::{
binding_types::uniform_buffer, BindGroup, BindGroupEntries, BindGroupLayoutDescriptor,
BindGroupLayoutEntries, CachedRenderPipelineId, CompareFunction, DepthStencilState,
FragmentState, MultisampleState, PipelineCache, RenderPipelineDescriptor, ShaderStages,
SpecializedRenderPipeline, SpecializedRenderPipelines,
DownlevelFlags, FragmentState, MultisampleState, PipelineCache, RenderPipelineDescriptor,
ShaderStages, SpecializedRenderPipeline, SpecializedRenderPipelines,
},
renderer::RenderDevice,
renderer::{RenderAdapter, RenderDevice},
sync_component::SyncComponent,
view::{Msaa, ViewUniform, ViewUniforms},
GpuResourceAppExt, Render, RenderApp, RenderStartup, RenderSystems,
Expand Down Expand Up @@ -84,19 +85,42 @@ pub struct BackgroundMotionVectorsBindGroup(pub BindGroup);
#[derive(Default)]
pub struct BackgroundMotionVectorsPlugin;

impl BackgroundMotionVectorsPlugin {
/// [`DownlevelFlags`] required for this plugin to function.
pub fn required_downlevel_flags() -> DownlevelFlags {
DownlevelFlags::INDEPENDENT_BLEND
}
}

impl Plugin for BackgroundMotionVectorsPlugin {
fn build(&self, app: &mut App) {
embedded_asset!(app, "background_motion_vectors.wgsl");

app.register_type::<NoBackgroundMotionVectors>()
.add_plugins(ExtractComponentPlugin::<NoBackgroundMotionVectors>::default());

let Some(render_app) = app.get_sub_app_mut(RenderApp) else {
return;
};
render_app.init_gpu_resource::<PreviousViewUniforms>();
}

fn finish(&self, app: &mut App) {
let Some(render_app) = app.get_sub_app_mut(RenderApp) else {
return;
};

let render_adapter = render_app.world().resource::<RenderAdapter>();
let downlevel_flags = render_adapter.get_downlevel_capabilities().flags;
if !downlevel_flags.contains(BackgroundMotionVectorsPlugin::required_downlevel_flags()) {
warn!(
"BackgroundMotionVectorsPlugin not loaded. GPU lacks support for required downlevel capability flags: {:?}.",
BackgroundMotionVectorsPlugin::required_downlevel_flags().difference(downlevel_flags)
);
return;
}

render_app
.init_gpu_resource::<SpecializedRenderPipelines<BackgroundMotionVectorsPipeline>>()
.init_gpu_resource::<PreviousViewUniforms>()
.add_systems(RenderStartup, init_background_motion_vectors_pipeline)
.add_systems(
Render,
Expand Down