best-effort reconciliation of modifier key states from winit#24845
Open
robtfm wants to merge 1 commit into
Open
best-effort reconciliation of modifier key states from winit#24845robtfm wants to merge 1 commit into
robtfm wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
in some circumstances modifier key events can be swallowed by the OS and lost to the application (e.g. macos screencap key chords like super+shift+5, potentially windows gamebar chord win+g). winit updates modifier state on any relevant event and provides an event stream, but bevy does not currently use those events.
Solution
add a reconciliation vs winit's modifier events
all platforms:
macos native only (relying on keycode press state, which is only reported accurately on macos currently, but could be supported on windows if winit extends support):
[1]winit reports only "pressed" or "unknown". to tell if a key is declared unpressed, we check if it is "unknown" and another key in the group is "pressed"
Testing
tested with https://github.com/robtfm/modifier-test-app (on macos native and wasm).