Very simple fix for where linear gradient is used as a border between…#24846
Open
gagnus wants to merge 1 commit into
Open
Very simple fix for where linear gradient is used as a border between…#24846gagnus wants to merge 1 commit into
gagnus wants to merge 1 commit into
Conversation
…, say, a slider and its background. Interpolating as SRGB involves a conversion in rust and conversion back in shader using different maths leading to slightly off colors, interpolating as linear is clean and produces exact results
ickshonpe
approved these changes
Jul 3, 2026
ickshonpe
left a comment
Contributor
There was a problem hiding this comment.
Yep, nice practical solution.
We should look into the mismatch in the colour conversion code though and see if its accuracy can be improved. I'll add an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, say, a slider and its background. Interpolating as SRGB involves a conversion in rust and conversion back in shader using different maths leading to slightly off colors, interpolating as linear is clean and produces exact results
Objective
Solution
Showcase
Before (annotation text added afterwards, difference is probably only visible with an eyedropper tool)