Feathers new select control and caption helper#24847
Open
gagnus wants to merge 5 commits into
Open
Conversation
… functionality, also added a simple caption helper that emits Text and a ThemedTest
… functionality, also added a simple caption helper that emits Text and a ThemedTest
…s://github.com/gagnus/bevy into feathers-new-select-control-and-caption-helper
Contributor
Author
|
I'm going to have a go at making the popup be at least same width as control |
viridia
reviewed
Jul 2, 2026
viridia
reviewed
Jul 2, 2026
| }; | ||
| let current = props.options.get(selected).cloned().unwrap_or_default(); | ||
|
|
||
| let rows: Box<dyn SceneList> = Box::new( |
Contributor
There was a problem hiding this comment.
Also, it would be good if we can support the appropriate a11y attributes: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-selected
Contributor
Author
There was a problem hiding this comment.
I think it does with the underlying list box but will check
… to review comments. Options is a scenelist rather than a list of strings, selection is by entity and that is picked up and sent on by a system. Note this has not gone as far as other controls in that it still manages its own events with on_select, I think the next step if we need to would be to make that optional like other controls do. This change also has a system for keeping the width of the popup in sync with the parent.
alice-i-cecile
added
C-Feature
alice-i-cecile
added
the
S-Waiting-on-Author
Contributor
|
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing
Showcase