Skip to content

Give render thread an explicit name#24848

Open
PJB3005 wants to merge 2 commits into
bevyengine:mainfrom
PJB3005:26-07-02-render-thread-name
Open

Give render thread an explicit name#24848
PJB3005 wants to merge 2 commits into
bevyengine:mainfrom
PJB3005:26-07-02-render-thread-name

Conversation

@PJB3005

@PJB3005 PJB3005 commented Jul 2, 2026

Copy link
Copy Markdown

Objective

  • Makes it show up nicer in tools like Tracy

Solution

  • std::thread::Builder::name()

Testing

  • Did you test these changes? If so, how?
    • Shows up in Tracy and System Informer.
  • Are there any parts that need more testing?
    • No
  • How can other people (reviewers) test your changes? Is there anything specific they need to know?
    • Check if the thread name shows up in Tracy ig
  • If relevant, what platforms did you test these changes on, and are there any important ones you can't test?
    • Windows

Showcase

image

@PJB3005
Give render thread an explicit name
66fc6ae 
Makes it show up nicer in tools like Tracy
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨

IceSentry
IceSentry reviewed Jul 2, 2026
View reviewed changes
Comment thread crates/bevy_render/src/pipelined_rendering.rs Outdated
IceSentry
IceSentry approved these changes Jul 2, 2026
View reviewed changes

@IceSentry IceSentry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor capitalization change needed but other than that LGTM

@IceSentry IceSentry added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 2, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Jul 2, 2026
@PJB3005 @IceSentry
Update crates/bevy_render/src/pipelined_rendering.rs
3b5cbcf 
Co-authored-by: IceSentry <IceSentry@users.noreply.github.com>
@Zeophlite Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@IceSentry IceSentry IceSentry approved these changes
@mardzie mardzie mardzie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Needs SME Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PJB3005 @IceSentry @mardzie @Zeophlite