Remove webgl2 render pass viewport workaround#24851
Open
beicause wants to merge 2 commits into
Open
Conversation
Member
I would love to remove it, but I would prefer to confirm it's ok on several browsers / os first. Could you list the ones you tested? |
Member
Author
|
I tested Linux Chromium and Firefox, Android Chromium |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The webgl2 workaround is added in #4967. It's old, and I didn't find any issues with the
split_screenexample on webgl2 after removing the workaround.Solution
Remove the webgl2 workaround
Testing