Skip to content

Remove webgl2 render pass viewport workaround#24851

Open
beicause wants to merge 2 commits into
bevyengine:mainfrom
beicause:remove-webgl2-viewport-workaround
Open

Remove webgl2 render pass viewport workaround#24851
beicause wants to merge 2 commits into
bevyengine:mainfrom
beicause:remove-webgl2-viewport-workaround

Conversation

@beicause

@beicause beicause commented Jul 3, 2026

Copy link
Copy Markdown
Member

Objective

The webgl2 workaround is added in #4967. It's old, and I didn't find any issues with the split_screen example on webgl2 after removing the workaround.

Solution

Remove the webgl2 workaround

Testing

cargo r -p build-wasm-example split_screen
屏幕截图_20260703_131252

@mockersf

mockersf commented Jul 4, 2026

Copy link
Copy Markdown
Member

The webgl2 workaround is added in #4967. It's old, and I didn't find any issues with the split_screen example on webgl2 after removing the workaround.

I would love to remove it, but I would prefer to confirm it's ok on several browsers / os first.

Could you list the ones you tested?

@beicause

beicause commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

I tested Linux Chromium and Firefox, Android Chromium

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Needs-Testing Testing must be done to verify an issue or fix labels Jul 5, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Jul 5, 2026
@alice-i-cecile alice-i-cecile added D-Straightforward Simple bug fixes and API improvements, docs, test and examples O-WebGL2 Specific to the WebGL2 render API labels Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples O-WebGL2 Specific to the WebGL2 render API S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Needs-Testing Testing must be done to verify an issue or fix

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

3 participants