Fix lifetime issues for native subexpressions in bsn! enum variants#24876
Open
akshitj11 wants to merge 1 commit into
Open
Fix lifetime issues for native subexpressions in bsn! enum variants#24876akshitj11 wants to merge 1 commit into
akshitj11 wants to merge 1 commit into
Conversation
Hoist native subexpressions in process_enum_field the same way process_field already does, so SceneFunction closures stay static.
958d16a to
17f52ef
Compare
alice-i-cecile
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bsn!lifts{...}expressions intolet _exprN = ...before buildingSceneFunctionclosures so they can be'static. That already worked for plain struct fields viaprocess_field, but not for fields inside enum variant patches likeFoo::Baz({expr}), which went throughprocess_enum_fieldand left the borrow inline in the closure.This adds the same hoisting branch to
process_enum_field.Fixes #24775
Test plan
cargo test -p bevy_scene_macroscargo test -p bevy_scene enum_variant_subexpressionsenum_variant_field_values_use_implicit_intostill passescargo fmton changed crates