Primitive ray casting#24883
Conversation
c9f385e to
d112510
Compare
- segment2d works differently compared to how it used to work ... adjust all code - Dir2 unchecked constructor spams a lot of warnings since most of the constructed dirs are not normalized ... use normalizing constructor
typos doesn't like the former even though it is technically correct. Semicircle is more widely known tho so I don't really get why we need to be so elitist...
d112510 to
1eba41e
Compare
7c5f826 to
a0d1a63
Compare
|
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
This is my preference too :) |
|
@alice-i-cecile is the Edit: I didn't touch any |
Objective
Solution
Showcase
Same as old PR
I don't know. I think we have a lot of new primitives that might need to be covered still. I don't really want to make this PR bigger than it needs to be so I would really love to merge this as is and create a detailed tracking issue (or update #10572?) to cover the rest of the unimplemented cases. I mean it already works to some extend and I'm willing to do follow up PRs so why not split it up and accept that we are in an unfinished intermediate state. What should go wrong? :P 💚