Skip to content

Primitive ray casting#24883

Open
JasmineLowen wants to merge 12 commits into
bevyengine:mainfrom
JasmineLowen:primitive-ray-casting
Open

Primitive ray casting#24883
JasmineLowen wants to merge 12 commits into
bevyengine:mainfrom
JasmineLowen:primitive-ray-casting

Conversation

@JasmineLowen

@JasmineLowen JasmineLowen commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Objective

Solution

  1. Rebase PR
  2. Fixed compiler errors and general things that changed
  3. fixed the examples to work as expected with new code
  4. fixed all the existing tests
  5. applied open review suggestions from old PR

Showcase

Same as old PR


I don't know. I think we have a lot of new primitives that might need to be covered still. I don't really want to make this PR bigger than it needs to be so I would really love to merge this as is and create a detailed tracking issue (or update #10572?) to cover the rest of the unimplemented cases. I mean it already works to some extend and I'm willing to do follow up PRs so why not split it up and accept that we are in an unfinished intermediate state. What should go wrong? :P 💚

@JasmineLowen JasmineLowen force-pushed the primitive-ray-casting branch from c9f385e to d112510 Compare July 5, 2026 18:16
Jondolf and others added 11 commits July 5, 2026 20:19
- segment2d works differently compared to how it used to work ... adjust
  all code
- Dir2 unchecked constructor spams a lot of warnings since most of the
  constructed dirs are not normalized ... use normalizing constructor
typos doesn't like the former even though it is technically correct.
Semicircle is more widely known tho so I don't really get why we need to
be so elitist...
@JasmineLowen JasmineLowen force-pushed the primitive-ray-casting branch from d112510 to 1eba41e Compare July 5, 2026 18:19
@JasmineLowen JasmineLowen force-pushed the primitive-ray-casting branch from 7c5f826 to a0d1a63 Compare July 5, 2026 18:28
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-Math Fundamental domain-agnostic mathematical operations M-Release-Note Work that should be called out in the blog due to impact X-Contentious There are nontrivial implications that should be thought through S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 5, 2026
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.

Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.

@alice-i-cecile

Copy link
Copy Markdown
Member

I think we have a lot of new primitives that might need to be covered still. I don't really want to make this PR bigger than it needs to be so I would really love to merge this as is and create a detailed tracking issue (or update #10572?) to cover the rest of the unimplemented cases

This is my preference too :)

@alice-i-cecile alice-i-cecile requested review from Jondolf and atlv24 July 5, 2026 18:56
@JasmineLowen

JasmineLowen commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

@alice-i-cecile is the check-advisories CI check my fault or something general wrong on main? It looks like it comes from the ttf-parser and quick-xml 🤔

Edit: I didn't touch any Cargo.* file so I assume the latter (mains fault + not on my plate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible M-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Contentious There are nontrivial implications that should be thought through

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants