FeathersSlider / bevy_ui_widgets/slider fixes#24905
Open
gagnus wants to merge 2 commits into
Open
Conversation
…ps as it doesn't exist in other controls (use SliderValue instead) and made SliderPrecision be correctly optional rather than silently not updating sliders if not present, in underlying UI widget only send ValueChange if value genuinely changes (matches other controls) rather than every time a SetSliderValue is added
|
This seems like a great simple change! |
viridia
approved these changes
Jul 7, 2026
viridia
left a comment
Contributor
There was a problem hiding this comment.
Thank you for doing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
: Removed value from
FeathersSliderPropsas it doesn't exist in other controls (useSliderValuecomponent instead) and madeSliderPrecisionbe correctly optional as it is in underlying UI widget rather than silently not updating sliders if not present, in underlying UI widget only sendValueChangeif value genuinely changes (matches other controls) rather than every time aSetSliderValueis addednote: slider may end up deprecated in favour of number input, but thought it best to leave it in working state
Objective
FeathersCheckbox) that would confuse users.Testing
Showcase
Missing SliderPrecision
Silently failed to update the slider, now it works.
value property (note: breaking change)
The above is different from other controls which use a component for value
Is the correct way of setting initial value
SetSliderValue
Would trigger ValueChange every time, even when some_value is the same as the existing value. Now it doesn't. This is the same as
SetChecked