Chore: Add debug logging for silent exception in RelationFinder.php#128
Open
zigzagdev wants to merge 3 commits into
Open
Chore: Add debug logging for silent exception in RelationFinder.php#128zigzagdev wants to merge 3 commits into
RelationFinder.php#128zigzagdev wants to merge 3 commits into
Conversation
812cfcd to
2949a6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What I have done
catch (\Throwable $e)block inRelationFinder::getRelationshipFromMethodAndModel().'debug_relations' => trueinconfig/erd-generator.php.Motivation
As reported in Issue #61, users have encountered silent failures inside the catch block of
getRelationshipFromMethodAndModel, making it difficult to diagnose why relations are not detected.This PR surfaces those errors in an opt-in manner, without polluting logs in production environments.
Changed
src/RelationFinder.php: WrappedLog::debug()with aconfig('erd-generator.debug_relations', false)guardconfig/erd-generator.php: Added commented-outdebug_relationsoption with descriptiontests/Fixtures/ModelWithThrowingMethod.php: Test model that throws an exceptiontests/GetModelRelationsTest.php: Test verifying the debug log outputTest Results