fix(canopy): set PGRO_REGION on the proxy sidecar from creds Secret#85
Merged
Conversation
The canopy-proxy binary reads PGRO_REGION as a required env var to sign outgoing S3 requests for the right region. Both the restore Job builder and the snapshot-list Job builder were plumbing PGRO_BROKER_URL / PGRO_GROUP / PGRO_TYPE / PGRO_STATS_CALLBACK_URL but had lost PGRO_REGION in the refactor. Sidecar exited at startup with 'canopy-proxy: PGRO_REGION not set' and the kopia container's port-file wait timed out. Region already lives on the namespace-local canopy-creds Secret the syncer materialises (`data.region`), so wire it via env_from_secret_name rather than adding a new field to KopiaSource / CanopySource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 The canopy-proxy binary reads
PGRO_REGIONas a required env var soit can sign outgoing S3 requests for the right region. Both the restore
Job builder and the snapshot-list Job builder were plumbing
PGRO_BROKER_URL/PGRO_GROUP/PGRO_TYPE/PGRO_STATS_CALLBACK_URLbut had lostPGRO_REGIONin the #82refactor. Sidecar exited at startup with
and the kopia container's port-file wait timed out.
Region already lives on the namespace-local canopy-creds Secret the
syncer materialises (
data.region), so wire it viaenv_from_secret_namerather than adding a new field toKopiaSource/CanopySource.