You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Overall: Clean, minimal caller workflow. Consistent with the existing pattern used in build-reporting-assets.yml (which also delegates to beyondessential/maui-team reusable workflows via secrets: inherit). No security issues — pull_request events from forks do not expose repo secrets, so there's no risk of credential exfiltration via a malicious PR.
🟡 Suggestion — pin the reusable workflow to a commit SHA
Referencing @main means any push to that branch silently changes what runs here. A compromised or accidentally broken upstream would affect this repo without any visible change in its own history. Consider pinning to a commit SHA (with the tag as a comment) for reproducibility and supply-chain safety:
uses: beyondessential/maui-team/.github/workflows/dbt-tests.yml@<commit-sha> # main
That said, the existing workflows in this repo (build-reporting-assets.yml, claude-code-review.yml) use @main consistently, so this is a repo-wide pattern — raising it here for awareness rather than blocking.
🔵 Nit — consider adding workflow_dispatch for manual reruns
When secrets are misconfigured or a transient DB connection issue occurs, there's no way to rerun without pushing a new commit. A workflow_dispatch trigger is low-cost insurance:
on:
pull_request:
types: [opened, reopened, synchronize]push:
branches: [main]workflow_dispatch:
.maui submodule
Submodule bump from 79ef2bd → bb8c5bd. Routine housekeeping to pick up the latest .maui baseline — no concerns.
Regression testing
# After secrets are configured in repo settings:# Open a test PR and verify the dbt-tests workflow appears and passes# Check Actions tab to confirm the reusable workflow resolves correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dbt-tests.ymlfrommaui-teamdbt testagainst a live database on PRs and pushes to mainDBT_HOST,DBT_DBNAME,DBT_USER, andDBT_PASSWORDrepository secrets to be configuredreporting(override viadbt-schemainput)Test plan
🤖 Generated with Claude Code