Merge pull request #82 from mhugot/feature/fix-warning-3

fix others warning

Author: mhugot

src/activities/TranscodeAssetActivity.php

@@ -33,6 +33,7 @@ class TranscodeAssetActivity extends BasicActivity
     const TMP_PATH_OPEN_FAIL    = "TMP_PATH_OPEN_FAIL";
 
     private $output;
+    private $outputs;
     private $outputFilesPath;
 
     public function __construct($client, $params, $debug, $cpeLogger)

src/activities/transcoders/BasicTranscoder.php

@@ -142,8 +142,8 @@ public function _extractFileInfo($metadata) {
                 'codec' => $videoStreams->codec_name,
                 'color' => @$videoStreams->color_space,
                 'resolution' => $videoStreams->width . 'x' . $videoStreams->height,
-                'sar' => $videoStreams->sample_aspect_ratio,
-                'dar' => $videoStreams->display_aspect_ratio,
+                'sar' => $videoStreams->sample_aspect_ratio ?? null,
+                'dar' => $videoStreams->display_aspect_ratio ?? null,
                 'framerate' => $videoStreams->r_frame_rate,
                 'bitrate' => isset($videoStreams->bit_rate) ? (int)$videoStreams->bit_rate : null
             ],

src/activities/transcoders/ImageTranscoder.php

@@ -39,7 +39,7 @@ public function transcode_asset(
         $tmpPathInput,
         $pathToInputFile,
         $pathToOutputFiles,
-        $metadata = null,
+        $metadata,
         $outputWanted)
     {
         if ($metadata) {

src/activities/transcoders/VideoTranscoder.php

@@ -59,7 +59,7 @@ public function transcode_asset(
         $tmpInputPath,
         $inputFilePath,
         $outputFilesPath,
-        $metadata = null,
+        $metadata,
         $outputWanted)
     {
         /* if (!$metadata) */
@@ -316,7 +316,7 @@ private function craft_ffmpeg_cmd_thumb(
                 $snapshot_sec = $outputWanted->{'snapshot_sec'};
             }
 
-            $time = gmdate("H:i:s", $snapshot_sec) . ".000";
+            $time = gmdate("H:i:s", (int)$snapshot_sec) . ".000";
             $outputFilesPath .= "/" . $outputFileInfo['basename'];
             $frameOptions = " -ss $time -vframes 1";
         }
@@ -481,7 +481,7 @@ private function set_output_video_size(&$metadata, $outputWanted)
             $height           = $outputSizeSplit[1];
 
             // We have a rotation. We flip width and height
-            if ($metadata['video']['tags'] &&
+            if (isset($metadata['video']['tags']) &&
                 $metadata['video']['tags']['rotate'] &&
                 ($metadata['video']['tags']['rotate'] == 90 ||
                  $metadata['video']['tags']['rotate'] == -90)) {
@@ -524,6 +524,9 @@ public function capture_progression($params, $out, $outErr)
         }
 
         // Perform Time transformation to get seconds
+        if ($last === null) {
+            return 0;
+        }
         $ar   = array_reverse(explode(":", $last));
         $done = floatval($ar[0]);
         if (!empty($ar[1])) {