Skip to content

Commit f445e51

Browse files
fix: skip settings on codeDiff if does not exisits (#26)
* fix: skip settings on codeDiff if does not exisits * fix: add changeset
1 parent 7721fbb commit f445e51

3 files changed

Lines changed: 9 additions & 3 deletions

File tree

.changeset/quick-sites-shine.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@bgd-labs/toolbox": patch
3+
"@bgd-labs/cli": patch
4+
---
5+
6+
Fix codeDiffs when no compiler settings provided by the explorer

packages/cli/src/tasks/code-diff.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export function registerCodeDiff(program: Command) {
5656
)
5757
: parseEtherscanStyleSourceCode(sources[0].SourceCode);
5858
const source2: StandardJsonInput = (
59-
sources[0] as BlockscoutStyleSourceCode
59+
sources[1] as BlockscoutStyleSourceCode
6060
).AdditionalSources
6161
? parseBlockscoutStyleSourceCode(
6262
sources[1] as BlockscoutStyleSourceCode,

packages/toolbox/src/operations/diffCode.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ export async function diffCode(
1111
) {
1212
const changes: Record<string, string> = {};
1313

14-
// diff settings
14+
// diff settings (skip if either source doesn't have settings, e.g. some explorers don't return it)
1515
const settingsBefore = JSON.stringify(before.settings, null, 2);
1616
const settingsAfter = JSON.stringify(after.settings, null, 2);
17-
if (settingsBefore !== settingsAfter)
17+
if (settingsBefore && settingsAfter && settingsBefore !== settingsAfter)
1818
changes.settings = createPatch("settings", settingsBefore, settingsAfter);
1919
const contractsBefore = await Promise.all(
2020
Object.entries(before.sources).map(async ([path, source]) => [

0 commit comments

Comments
 (0)