Validate release smoke timing environment

Author: bhack

tests/test_release_preflight.py

@@ -88,6 +88,23 @@ def test_release_preflight_runs_headless_pipewire_runtime_smoke(monkeypatch) ->
     ]
 
 
+def test_release_preflight_rejects_invalid_headless_pipewire_runtime_env(monkeypatch) -> None:
+    def fail_run(_command, **_kwargs) -> None:
+        raise AssertionError("Headless runtime smoke should not run with invalid environment")
+
+    monkeypatch.setenv("MINI_EQ_HEADLESS_PIPEWIRE_CYCLES", "2; touch unexpected")
+    monkeypatch.setattr(release_preflight, "run", fail_run)
+
+    try:
+        release_preflight.run_headless_pipewire_runtime_smoke(Path("/python"))
+    except SystemExit as error:
+        message = str(error)
+        assert "MINI_EQ_HEADLESS_PIPEWIRE_CYCLES" in message
+        assert "integer between 1 and 20" in message
+    else:
+        raise AssertionError("Expected invalid headless runtime smoke environment to fail")
+
+
 def test_flatpak_pipewire_gobject_pin_accepts_matching_floor(tmp_path: Path) -> None:
     (tmp_path / "pyproject.toml").write_text(
         '[project]\ndependencies = ["pipewire-gobject>=0.3.7,<0.4"]\n',

tools/release_preflight.py

@@ -90,6 +90,19 @@ def require_tools(*tools: str) -> None:
         raise SystemExit(f"Missing required release tool(s): {', '.join(missing)}")
 
 
+def bounded_int_env(name: str, default: int, *, minimum: int, maximum: int) -> str:
+    value = os.environ.get(name, str(default)).strip()
+    try:
+        parsed = int(value)
+    except ValueError:
+        raise SystemExit(f"{name} must be an integer between {minimum} and {maximum}") from None
+
+    if not minimum <= parsed <= maximum:
+        raise SystemExit(f"{name} must be an integer between {minimum} and {maximum}")
+
+    return str(parsed)
+
+
 def allowed_leak_match(line: str) -> bool:
     return any(allowed in line for allowed in ALLOWED_LEAK_MATCHES)
 
@@ -424,9 +437,14 @@ def run_build_checks(python: Path) -> None:
 
 
 def run_headless_pipewire_runtime_smoke(python: Path) -> None:
-    timeout = os.environ.get("MINI_EQ_HEADLESS_PIPEWIRE_TIMEOUT", "35")
-    cycles = os.environ.get("MINI_EQ_HEADLESS_PIPEWIRE_CYCLES", "2")
-    audio_duration = os.environ.get("MINI_EQ_HEADLESS_PIPEWIRE_AUDIO_DURATION", "90")
+    timeout = bounded_int_env("MINI_EQ_HEADLESS_PIPEWIRE_TIMEOUT", 35, minimum=1, maximum=600)
+    cycles = bounded_int_env("MINI_EQ_HEADLESS_PIPEWIRE_CYCLES", 2, minimum=1, maximum=20)
+    audio_duration = bounded_int_env(
+        "MINI_EQ_HEADLESS_PIPEWIRE_AUDIO_DURATION",
+        90,
+        minimum=1,
+        maximum=3600,
+    )
     run(
         [
             python,