Skip to content

Commit 6998395

Browse files
committed
Relax hosted headless PipeWire smoke timeout
1 parent f47e63d commit 6998395

4 files changed

Lines changed: 31 additions & 4 deletions

File tree

tests/test_github_workflows.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,14 @@ def test_ci_scope_treats_release_workflow_and_release_gate_tools_as_tested_chang
9090
def test_headless_pipewire_runtime_smoke_is_optional_ci_gate_without_nested_gnome() -> None:
9191
ci_yml = workflow_text("ci.yml")
9292
job = ci_yml.partition("headless-pipewire-runtime-smoke:")[2].partition("live-ui-runtime-smoke:")[0]
93+
script = (ROOT / "tools/run_headless_pipewire_runtime_smoke_ci.sh").read_text(encoding="utf-8")
9394

9495
assert "headless_pipewire_runtime_smoke" in ci_yml
9596
assert "tools/run_headless_pipewire_runtime_smoke_ci.sh" in job
9697
assert "gnome-shell" not in job
9798
assert "python3-pyatspi" not in job
99+
assert 'timeout="${MINI_EQ_HEADLESS_PIPEWIRE_TIMEOUT:-90}"' in script
100+
assert 'audio_duration="${MINI_EQ_HEADLESS_PIPEWIRE_AUDIO_DURATION:-180}"' in script
98101

99102

100103
def test_live_ui_runtime_smoke_uses_host_gir_build_environment() -> None:

tests/test_release_preflight.py

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,30 @@ def test_release_preflight_runs_headless_pipewire_runtime_smoke(monkeypatch) ->
9797
]
9898

9999

100+
def test_release_preflight_uses_hosted_headless_pipewire_defaults(monkeypatch) -> None:
101+
commands: list[list[str | Path]] = []
102+
103+
monkeypatch.delenv("MINI_EQ_HEADLESS_PIPEWIRE_TIMEOUT", raising=False)
104+
monkeypatch.delenv("MINI_EQ_HEADLESS_PIPEWIRE_CYCLES", raising=False)
105+
monkeypatch.delenv("MINI_EQ_HEADLESS_PIPEWIRE_AUDIO_DURATION", raising=False)
106+
monkeypatch.setattr(release_preflight, "run", lambda command, **_kwargs: commands.append(command))
107+
108+
release_preflight.run_headless_pipewire_runtime_smoke(Path("/python"))
109+
110+
assert commands == [
111+
[
112+
Path("/python"),
113+
release_preflight.ROOT / "tools/check_headless_pipewire_runtime.py",
114+
"--timeout",
115+
"90",
116+
"--cycles",
117+
"2",
118+
"--audio-duration",
119+
"180",
120+
]
121+
]
122+
123+
100124
def test_release_preflight_rejects_invalid_headless_pipewire_runtime_env(monkeypatch) -> None:
101125
def fail_run(_command, **_kwargs) -> None:
102126
raise AssertionError("Headless runtime smoke should not run with invalid environment")

tools/release_preflight.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,11 +449,11 @@ def run_build_checks(python: Path) -> None:
449449

450450

451451
def run_headless_pipewire_runtime_smoke(python: Path) -> None:
452-
timeout = bounded_int_env("MINI_EQ_HEADLESS_PIPEWIRE_TIMEOUT", 35, minimum=1, maximum=600)
452+
timeout = bounded_int_env("MINI_EQ_HEADLESS_PIPEWIRE_TIMEOUT", 90, minimum=1, maximum=600)
453453
cycles = bounded_int_env("MINI_EQ_HEADLESS_PIPEWIRE_CYCLES", 2, minimum=1, maximum=20)
454454
audio_duration = bounded_int_env(
455455
"MINI_EQ_HEADLESS_PIPEWIRE_AUDIO_DURATION",
456-
90,
456+
180,
457457
minimum=1,
458458
maximum=3600,
459459
)

tools/run_headless_pipewire_runtime_smoke_ci.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
set -eu
33

44
venv="${MINI_EQ_HEADLESS_PIPEWIRE_VENV:-${RUNNER_TEMP:-/tmp}/mini-eq-headless-pipewire-venv}"
5-
timeout="${MINI_EQ_HEADLESS_PIPEWIRE_TIMEOUT:-35}"
5+
timeout="${MINI_EQ_HEADLESS_PIPEWIRE_TIMEOUT:-90}"
66
cycles="${MINI_EQ_HEADLESS_PIPEWIRE_CYCLES:-3}"
7-
audio_duration="${MINI_EQ_HEADLESS_PIPEWIRE_AUDIO_DURATION:-120}"
7+
audio_duration="${MINI_EQ_HEADLESS_PIPEWIRE_AUDIO_DURATION:-180}"
88

99
repo_root="$(git rev-parse --show-toplevel)"
1010
cd "$repo_root"

0 commit comments

Comments
 (0)