Prepare Mini EQ 0.7.2 release

bhack · bhack · commit 956b16b3574f · 2026-05-10T01:11:15.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,14 @@
 # Changelog
 
+## 0.7.2 - 2026-05-10
+
+- Finish GNOME Shell startup notification after Mini EQ's delayed first-window
+  setup, avoiding a stuck busy cursor when launching from the app icon.
+- Rename the delayed startup setup path in code to make the readiness barrier
+  clearer for future maintenance.
+- Clarify the unmatched-output fallback action so it refers to the loaded saved
+  preset instead of the ambiguous current curve.
+
 ## 0.7.1 - 2026-05-09
 
 - Fix port-aware auto presets when the active port changes on the same
diff --git a/data/io.github.bhack.mini-eq.metainfo.xml b/data/io.github.bhack.mini-eq.metainfo.xml
@@ -33,18 +33,27 @@
   </description>
   <screenshots>
     <screenshot type="default">
-      <image>https://raw.githubusercontent.com/bhack/mini-eq/v0.7.1/docs/screenshots/mini-eq.png</image>
+      <image>https://raw.githubusercontent.com/bhack/mini-eq/v0.7.2/docs/screenshots/mini-eq.png</image>
       <caption>Adjust sound output with equalizer controls</caption>
     </screenshot>
     <screenshot>
-      <image>https://raw.githubusercontent.com/bhack/mini-eq/v0.7.1/docs/screenshots/mini-eq-dark.png</image>
+      <image>https://raw.githubusercontent.com/bhack/mini-eq/v0.7.2/docs/screenshots/mini-eq-dark.png</image>
       <caption>Use the equalizer with dark style</caption>
     </screenshot>
   </screenshots>
   <url type="homepage">https://github.com/bhack/mini-eq</url>
   <url type="bugtracker">https://github.com/bhack/mini-eq/issues</url>
   <url type="vcs-browser">https://github.com/bhack/mini-eq</url>
   <releases>
+    <release version="0.7.2" date="2026-05-10">
+      <description>
+        <ul>
+          <li>Finish GNOME Shell startup notification after delayed first-window setup.</li>
+          <li>Clarify the unmatched-output fallback action wording.</li>
+          <li>Rename startup-readiness code paths for clearer maintenance.</li>
+        </ul>
+      </description>
+    </release>
     <release version="0.7.1" date="2026-05-09">
       <description>
         <ul>
diff --git a/pyproject.toml b/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "mini-eq"
-version = "0.7.1"
+version = "0.7.2"
 description = "Compact PipeWire system-wide parametric equalizer for Linux desktops."
 readme = "README.md"
 requires-python = ">=3.11"
diff --git a/src/mini_eq/app.py b/src/mini_eq/app.py
@@ -7,9 +7,10 @@
 import gi
 
 gi.require_version("Adw", "1")
+gi.require_version("Gdk", "4.0")
 gi.require_version("GLibUnix", "2.0")
 
-from gi.repository import Adw, Gio, GLib, GLibUnix
+from gi.repository import Adw, Gdk, Gio, GLib, GLibUnix
 
 from .appearance import apply_appearance_preference, load_appearance_preference
 from .background import (
@@ -84,12 +85,13 @@ def ensure_window(self, *, present: bool) -> None:
             if self.window.ui_shutting_down:
                 return
             if present:
-                self.window.present_after_setup = True
-                if self.window.post_present_ready:
+                self.window.present_when_ready = True
+                if self.window.startup_ready:
                     self.window.set_visible(True)
                     self.window.present()
+                    self.finish_startup_notification()
                     self.emit_control_state_changed()
-            self.window.schedule_post_present_setup()
+            self.window.schedule_startup_ready()
             return
 
         controller: SystemWideEqController | None = None
@@ -110,9 +112,9 @@ def ensure_window(self, *, present: bool) -> None:
         self.controller = controller
         self.window = MiniEqWindow(self, self.controller, self.args.auto_route, initial_curve_label=initial_curve_label)
         self.window.set_icon_name(APP_ICON_NAME)
-        self.window.present_after_setup = present
+        self.window.present_when_ready = present
         self.window.set_visible(False)
-        self.window.schedule_post_present_setup()
+        self.window.schedule_startup_ready()
         if not present:
             self.update_background_status()
             self.emit_control_state_changed()
@@ -162,8 +164,20 @@ def on_window_present_idle(self) -> bool:
             return False
 
         self.window.present()
+        self.finish_startup_notification()
         return False
 
+    def finish_startup_notification(self) -> None:
+        display = Gdk.Display.get_default()
+        if display is None:
+            return
+
+        startup_id = display.get_startup_notification_id()
+        if not startup_id:
+            return
+
+        display.notify_startup_complete(startup_id)
+
     def emit_control_state_changed(self) -> None:
         if self.window is not None and not self.window.get_visible():
             self.update_background_status()
diff --git a/src/mini_eq/window.py b/src/mini_eq/window.py
@@ -143,10 +143,10 @@ def __init__(
         self.add_css_class("mini-eq-window")
         self.controller = controller
         self.auto_route_on_startup = auto_route
-        self.post_present_source_id = 0
+        self.startup_ready_source_id = 0
         self.startup_auto_route_source_id = 0
-        self.post_present_ready = False
-        self.present_after_setup = True
+        self.startup_ready = False
+        self.present_when_ready = True
         self.responsive_layout_source_id = 0
         self.responsive_layout_size = (0, 0)
         self.toast_overlay: Adw.ToastOverlay | None = None
@@ -291,19 +291,19 @@ def on_responsive_layout_idle(self) -> bool:
             sync_responsive_layout(*self.responsive_layout_size)
         return False
 
-    def schedule_post_present_setup(self) -> None:
-        if self.post_present_ready or self.post_present_source_id != 0:
+    def schedule_startup_ready(self) -> None:
+        if self.startup_ready or self.startup_ready_source_id != 0:
             return
 
-        self.post_present_source_id = GLib.idle_add(self.on_post_present_setup_idle)
+        self.startup_ready_source_id = GLib.idle_add(self.on_startup_ready_idle)
 
-    def on_post_present_setup_idle(self) -> bool:
-        self.post_present_source_id = 0
+    def on_startup_ready_idle(self) -> bool:
+        self.startup_ready_source_id = 0
 
-        if self.ui_shutting_down or self.post_present_ready:
+        if self.ui_shutting_down or self.startup_ready:
             return False
 
-        self.post_present_ready = True
+        self.startup_ready = True
         self.start_preset_monitoring()
         self.apply_output_preset_for_current_output()
 
@@ -314,9 +314,14 @@ def on_post_present_setup_idle(self) -> bool:
         if self.auto_route_on_startup:
             self.apply_startup_auto_route()
 
-        if not self.ui_shutting_down and self.present_after_setup:
-            self.set_visible(True)
-            self.present()
+        if not self.ui_shutting_down:
+            if self.present_when_ready:
+                self.set_visible(True)
+                self.present()
+            application = self.get_application()
+            finish_startup_notification = getattr(application, "finish_startup_notification", None)
+            if callable(finish_startup_notification):
+                finish_startup_notification()
         self.notify_control_state_changed()
         return False
 
@@ -349,9 +354,9 @@ def prepare_for_shutdown(self) -> None:
 
         self.ui_shutting_down = True
         self.controller.shutting_down = True
-        if self.post_present_source_id > 0:
-            destroy_glib_source(self.post_present_source_id)
-            self.post_present_source_id = 0
+        if self.startup_ready_source_id > 0:
+            destroy_glib_source(self.startup_ready_source_id)
+            self.startup_ready_source_id = 0
         if self.startup_auto_route_source_id > 0:
             destroy_glib_source(self.startup_auto_route_source_id)
             self.startup_auto_route_source_id = 0
@@ -476,7 +481,7 @@ def on_status_idle(self, message: str) -> bool:
         if self.ui_shutting_down:
             return False
 
-        if not self.post_present_ready or message.startswith(TOAST_IGNORED_PREFIXES) or self.toast_overlay is None:
+        if not self.startup_ready or message.startswith(TOAST_IGNORED_PREFIXES) or self.toast_overlay is None:
             return False
 
         toast = Adw.Toast.new(self.status_toast_title(message))
@@ -855,7 +860,7 @@ def refresh_output_sinks(self, *, handle_observed_output_change: bool = True) ->
         self.update_info_label()
         self.update_status_summary()
 
-        if self.post_present_ready and handle_observed_output_change and output_changed:
+        if self.startup_ready and handle_observed_output_change and output_changed:
             self.apply_output_preset_for_current_output(
                 reset_auto_preset_without_link=previous_output_preset_auto_loaded,
                 announce_no_output_preset=True,
diff --git a/src/mini_eq/window_presets.py b/src/mini_eq/window_presets.py
@@ -617,7 +617,9 @@ def refresh_preset_actions(self, state: PresetPanelUiState | None = None) -> Non
             state.default_set_visible or state.default_clear_visible,
         )
         self.default_preset_set_button.set_sensitive(state.default_set_visible)
-        self.default_preset_set_button.set_tooltip_text("Use the current preset when no auto preset matches")
+        self.default_preset_set_button.set_tooltip_text(
+            "Use the loaded saved preset when an output has no auto preset."
+        )
         self.default_preset_clear_button.set_sensitive(state.default_clear_visible)
         self.default_preset_clear_button.set_tooltip_text(
             "Bypass unmatched outputs instead of loading a fallback preset"
diff --git a/src/mini_eq/window_utility.py b/src/mini_eq/window_utility.py
@@ -184,7 +184,7 @@ def make_preset_action(label: str, callback, *, destructive: bool = False) -> tu
         preset_more_box.append(self.preset_default_heading)
 
         self.default_preset_set_button, self.default_preset_set_button_label = make_preset_action(
-            "Use Current as Fallback",
+            "Use Loaded as Fallback",
             self.on_use_preset_as_fallback_clicked,
         )
 
diff --git a/tests/test_mini_eq_app.py b/tests/test_mini_eq_app.py
@@ -59,49 +59,86 @@ def test_window_present_idle_skips_window_during_shutdown() -> None:
 
 def test_window_present_idle_presents_active_window() -> None:
     window = FakeWindow(ui_shutting_down=False)
-    application = SimpleNamespace(window=window, window_present_source_id=123)
+    calls: list[str] = []
+    application = SimpleNamespace(
+        window=window,
+        window_present_source_id=123,
+        finish_startup_notification=lambda: calls.append("startup-complete"),
+    )
 
     assert app.MiniEqApplication.on_window_present_idle(application) is False
     assert application.window_present_source_id == 0
     assert window.present_count == 1
+    assert calls == ["startup-complete"]
 
 
-def test_ensure_window_defers_existing_window_present_until_setup(monkeypatch) -> None:
+def test_ensure_window_defers_existing_window_present_until_startup_ready(monkeypatch) -> None:
     monkeypatch.setattr(app, "install_app_icon", lambda: None)
     calls: list[object] = []
     window = SimpleNamespace(
         ui_shutting_down=False,
-        post_present_ready=False,
-        present_after_setup=False,
+        startup_ready=False,
+        present_when_ready=False,
         set_visible=lambda visible: calls.append(("visible", visible)),
         present=lambda: calls.append("present"),
-        schedule_post_present_setup=lambda: calls.append("setup"),
+        schedule_startup_ready=lambda: calls.append("ready-scheduled"),
+    )
+    application = SimpleNamespace(
+        window=window,
+        emit_control_state_changed=lambda: calls.append("state"),
+        finish_startup_notification=lambda: calls.append("startup-complete"),
     )
-    application = SimpleNamespace(window=window, emit_control_state_changed=lambda: calls.append("state"))
 
     app.MiniEqApplication.ensure_window(application, present=True)
 
-    assert window.present_after_setup is True
-    assert calls == ["setup"]
+    assert window.present_when_ready is True
+    assert calls == ["ready-scheduled"]
 
 
 def test_ensure_window_presents_existing_ready_window_immediately(monkeypatch) -> None:
     monkeypatch.setattr(app, "install_app_icon", lambda: None)
     calls: list[object] = []
     window = SimpleNamespace(
         ui_shutting_down=False,
-        post_present_ready=True,
-        present_after_setup=False,
+        startup_ready=True,
+        present_when_ready=False,
         set_visible=lambda visible: calls.append(("visible", visible)),
         present=lambda: calls.append("present"),
-        schedule_post_present_setup=lambda: calls.append("setup"),
+        schedule_startup_ready=lambda: calls.append("ready-scheduled"),
+    )
+    application = SimpleNamespace(
+        window=window,
+        emit_control_state_changed=lambda: calls.append("state"),
+        finish_startup_notification=lambda: calls.append("startup-complete"),
     )
-    application = SimpleNamespace(window=window, emit_control_state_changed=lambda: calls.append("state"))
 
     app.MiniEqApplication.ensure_window(application, present=True)
 
-    assert window.present_after_setup is True
-    assert calls == [("visible", True), "present", "state", "setup"]
+    assert window.present_when_ready is True
+    assert calls == [("visible", True), "present", "startup-complete", "state", "ready-scheduled"]
+
+
+def test_finish_startup_notification_completes_current_gdk_startup_id(monkeypatch) -> None:
+    calls: list[object] = []
+    display = SimpleNamespace(
+        get_startup_notification_id=lambda: "mini-eq-startup",
+        notify_startup_complete=lambda startup_id: calls.append(("complete", startup_id)),
+    )
+    monkeypatch.setattr(app.Gdk.Display, "get_default", lambda: display)
+
+    app.MiniEqApplication.finish_startup_notification(SimpleNamespace())
+
+    assert calls == [("complete", "mini-eq-startup")]
+
+
+def test_finish_startup_notification_ignores_missing_gdk_startup_id(monkeypatch) -> None:
+    display = SimpleNamespace(
+        get_startup_notification_id=lambda: None,
+        notify_startup_complete=lambda _startup_id: (_ for _ in ()).throw(AssertionError("unexpected")),
+    )
+    monkeypatch.setattr(app.Gdk.Display, "get_default", lambda: display)
+
+    app.MiniEqApplication.finish_startup_notification(SimpleNamespace())
 
 
 def test_close_action_closes_active_window() -> None:
diff --git a/tests/test_mini_eq_output_presets.py b/tests/test_mini_eq_output_presets.py
@@ -1179,7 +1179,7 @@ def test_pipewire_observed_output_change_runs_output_preset_handling() -> None:
         last_output_preset_sink_name="alsa_output.speakers",
         output_preset_auto_applied=True,
         output_preset_curve_auto_loaded=True,
-        post_present_ready=True,
+        startup_ready=True,
         list_visible_output_sinks=lambda: [],
         build_output_sink_labels=lambda _sinks: [],
         follow_default_output_label=lambda: "Follow system output",
@@ -1225,7 +1225,7 @@ def test_pipewire_observed_port_scope_change_runs_output_preset_handling() -> No
         last_output_preset_target_identity=old_route_key,
         output_preset_auto_applied=True,
         output_preset_curve_auto_loaded=True,
-        post_present_ready=True,
+        startup_ready=True,
         list_visible_output_sinks=lambda: [],
         build_output_sink_labels=lambda _sinks: [],
         follow_default_output_label=lambda: "Follow system output",
@@ -1266,7 +1266,7 @@ def test_manual_output_refresh_updates_selector_without_handling_observed_output
         last_output_preset_sink_name="alsa_output.speakers",
         output_preset_auto_applied=True,
         output_preset_curve_auto_loaded=False,
-        post_present_ready=True,
+        startup_ready=True,
         list_visible_output_sinks=lambda: [],
         build_output_sink_labels=lambda _sinks: [],
         follow_default_output_label=lambda: "Follow system output",
@@ -1315,7 +1315,7 @@ def test_missing_manual_output_stays_visible_in_selector() -> None:
         last_output_preset_sink_name=None,
         output_preset_auto_applied=False,
         output_preset_curve_auto_loaded=False,
-        post_present_ready=True,
+        startup_ready=True,
         list_visible_output_sinks=lambda: [visible_sink],
         build_output_sink_labels=lambda _sinks: ["USB DAC"],
         follow_default_output_label=lambda: "Follow system output (USB DAC)",
diff --git a/tests/test_mini_eq_window.py b/tests/test_mini_eq_window.py

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ def make_preset_action(label: str, callback, *, destructive: bool = False) -> tu`
`184`	`184`	`preset_more_box.append(self.preset_default_heading)`
`185`	`185`
`186`	`186`	`self.default_preset_set_button, self.default_preset_set_button_label = make_preset_action(`
`187`		`- "Use Current as Fallback",`
	`187`	`+ "Use Loaded as Fallback",`
`188`	`188`	`self.on_use_preset_as_fallback_clicked,`
`189`	`189`	`)`
`190`	`190`