Skip to content

get country by code_phone#72

Open
majidtaherkhani wants to merge 3 commits intobhatvikrant:masterfrom
majidtaherkhani:master
Open

get country by code_phone#72
majidtaherkhani wants to merge 3 commits intobhatvikrant:masterfrom
majidtaherkhani:master

Conversation

@majidtaherkhani
Copy link
Copy Markdown

General

Reference: <ISSUE_ID>


Description:

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Additional notes

Comment thread index.js
* @returns {Array} An array of country objects
*/
const getCountryDetailsBylanguageCodes = (language_code) => {
let resultArray = [];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majidtaherkhani

Suggested change
let resultArray = [];
return data.filter(item => item["language_codes"].includes(language_code))

@harshsaini786
Copy link
Copy Markdown
Contributor

nit - @majidtaherkhani try to use filter function instead of pushing result in an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants