fix: fixing an issue ran into while trying out renamed on annexed file#5
Closed
yarikoptic wants to merge 2 commits into
Closed
fix: fixing an issue ran into while trying out renamed on annexed file#5yarikoptic wants to merge 2 commits into
yarikoptic wants to merge 2 commits into
Conversation
BUG FIX: cli/rename.py used Path.resolve() which follows symlinks, resolving annexed files to .git/annex/objects/ paths — git mv then fails. Fix: use Path.absolute() instead. Also fix rename.py exists() checks to include is_symlink() for annexed files. Constitution v1.5.0: Principle VII elevated to NON-NEGOTIABLE for git-annex. Added explicit rules: never use resolve() on potential symlinks, never use bare exists(), never use is_file() for iteration. Principle V updated: git-annex testing is mandatory (bids-examples sweep must run in both plain-git and git-annex modes). T078 updated: bids-examples sweep now requires two modes — plain git and git-annex (clone + force all files into annex) — verifying equivalent results. Co-Authored-By: Claude Code 2.1.101 / Claude Opus 4.6 <noreply@anthropic.com> Entire-Checkpoint: 5f2ad6ae099b
Add git-annex integration tests: clone bids-examples datasets, force all files into annex, then run rename, subject-rename, and session-rename. Verifies no files retain old labels after rename on symlinked datasets. 18 new annex integration tests across 5 representative datasets (ds001, 7t_trt, synthetic, eeg_matchingpennies, ieeg_visual). All operations succeed on annexed datasets with locked symlinks. Also fix is_file() in _find_run_file test helper. 1086 integration tests pass (1068 plain + 18 annex). All tox envs green. Co-Authored-By: Claude Code 2.1.101 / Claude Opus 4.6 <noreply@anthropic.com> Entire-Checkpoint: 8dfbc7635c4f
Contributor
Author
|
will be doing dance with branches renaming etc |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.