-
Notifications
You must be signed in to change notification settings - Fork 206
Add "preUploadedPresentation" and "preUploadedPresentationName" to create #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
927887a
Add "preUploadedPresentation" and "preUploadedPresentationName" to cr…
nimah79 38f3119
Rename bigbluebutton to nimah79 to be able to release the package in …
nimah79 5ee4c9e
Revert "Rename bigbluebutton to nimah79 to be able to release the pac…
nimah79 f275161
Fix code style
nimah79 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -150,6 +150,10 @@ class CreateMeetingParameters extends MetaParameters | |
|
|
||
| private ?int $meetingExpireWhenLastUserLeftInMinutes = null; | ||
|
|
||
| private ?string $preUploadedPresentation = null; | ||
|
|
||
| private ?string $preUploadedPresentationName = null; | ||
|
|
||
| private ?bool $preUploadedPresentationOverrideDefault = null; | ||
|
|
||
| /** | ||
|
|
@@ -1218,6 +1222,31 @@ public function isPreUploadedPresentationOverrideDefault(): ?bool | |
| return $this->preUploadedPresentationOverrideDefault; | ||
| } | ||
|
|
||
| /** | ||
| * If passed with a valid presentation file url, this presentation will override the default presentation. | ||
| * To only upload but not set as default, also pass preUploadedPresentationOverrideDefault=false | ||
| * | ||
| * @since 2.7.2 | ||
| */ | ||
| public function setPreUploadedPresentation(string $preUploadedPresentation): self | ||
| { | ||
| $this->preUploadedPresentation = $preUploadedPresentation; | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| /** | ||
| * If passed it will use this string as the name of the presentation uploaded via preUploadedPresentation | ||
| * | ||
| * @since 2.7.2 | ||
| */ | ||
| public function setPreUploadedPresentationName(string $preUploadedPresentationName): self | ||
| { | ||
| $this->preUploadedPresentationName = $preUploadedPresentationName; | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| /** | ||
| * If it is true, the default.pdf document is not sent along with the other presentations in the /create | ||
| * endpoint, on the other hand, if that's false, the default.pdf is sent with the other documents. | ||
|
|
@@ -1449,6 +1478,8 @@ public function getHTTPQuery(): string | |
| 'userCameraCap' => $this->userCameraCap, | ||
| 'meetingExpireIfNoUserJoinedInMinutes' => $this->meetingExpireIfNoUserJoinedInMinutes, | ||
| 'meetingExpireWhenLastUserLeftInMinutes' => $this->meetingExpireWhenLastUserLeftInMinutes, | ||
| 'preUploadedPresentation' => $this->preUploadedPresentation, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to apply code formatting here.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
| 'preUploadedPresentationName' => $this->preUploadedPresentationName, | ||
| 'preUploadedPresentationOverrideDefault' => $this->preUploadedPresentationOverrideDefault, | ||
| 'disabledFeatures' => join(',', $this->disabledFeatures), | ||
| 'disabledFeaturesExclude' => join(',', $this->disabledFeaturesExclude), | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert this one please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.