fix: remove onSelectSlot event handler as its only creating empty ev…#2590
Open
geraldhoxha95 wants to merge 1 commit into
Open
fix: remove onSelectSlot event handler as its only creating empty ev…#2590geraldhoxha95 wants to merge 1 commit into
geraldhoxha95 wants to merge 1 commit into
Conversation
5 tasks
geraldhoxha95
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was that clicking on a date on the calendar was creating empty events that would fill up the calendar.
This was happening because the
onSelectSlotprop was linked to thenewEventfunction, which was creating empty events.Removed
onSelectSlot.Functionality now more in align with the other storybook section, Basic Drag n Drop, where clicking on the dates does not do anything.
Closes #2587