Skip to content

Add handleInteractionEnd to dropFromOutside to cleanup preview.#2690

Open
ardenc wants to merge 2 commits into
bigcalendar:masterfrom
ardenc:remove-preview-after-drop-from-outside
Open

Add handleInteractionEnd to dropFromOutside to cleanup preview.#2690
ardenc wants to merge 2 commits into
bigcalendar:masterfrom
ardenc:remove-preview-after-drop-from-outside

Conversation

@ardenc
Copy link
Copy Markdown

@ardenc ardenc commented Dec 3, 2024

Howdy,

I as well as a few other users have had a problem with trying to manually control the state for items dropped from outside.

Current behavior drops the preview onto the calendar. This is not desired as it interferes with trying to adjust the date and event after drop.

Use Case Example: Not allowing dropping from outside on specific calendar days.

Related issues
#2675
#2294

If you want me to change anything just let me know!

@proohit
Copy link
Copy Markdown

proohit commented Dec 7, 2024

Hey, I just tried this patch but it still drops the preview event onto the calendar. How did you get it to work? I want the preview still to be visible while dragging and then update my state manually with onDropFromOutside

EDIT: nevermind, I forgot to actually update the onEventDrop to update my events. So yeah, thanks for this PR!

@ardenc
Copy link
Copy Markdown
Author

ardenc commented Dec 17, 2024

@cutterbl Hi, sorry to ping you. Would you be able to review this pull request to see if it is something that can be incorporated into the source?

If you have any questions or want me to update anything just let me know.

,Thanks

@Chrstnp
Copy link
Copy Markdown

Chrstnp commented Feb 5, 2025

Any update on this? it is affecting me as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants