chore(deps): bump react-datepicker from 7.3.0 to 8.10.0#1799
chore(deps): bump react-datepicker from 7.3.0 to 8.10.0#1799dependabot[bot] wants to merge 1 commit into
Conversation
|
| @@ -43,7 +43,7 @@ | |||
| "focus-trap": "^7.6.4", | |||
| "polished": "^4.3.1", | |||
| "react-beautiful-dnd": "^13.1.1", | |||
There was a problem hiding this comment.
Bug: Datepicker component loses manual input on blur due to react-datepicker v8.6.0+ behavior and missing onChangeRaw implementation.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The Datepicker component allows manual input but does not manage inputValue or implement onChangeRaw. When a user types a date manually and then blurs the input field, react-datepicker v8.6.0+ resets inputValue to null. This behavior, combined with the component's lack of handling for partially parsed dates, causes the user's typed input to silently disappear from the field if it wasn't fully parsed into a Date object, leading to data loss.
💡 Suggested Fix
Implement onChangeRaw with proper date validation to handle manual input, or manage the inputValue prop to persist values, or explicitly document that manual input is not supported by the component.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/big-design/package.json#L45
Potential issue: The `Datepicker` component allows manual input but does not manage
`inputValue` or implement `onChangeRaw`. When a user types a date manually and then
blurs the input field, `react-datepicker` v8.6.0+ resets `inputValue` to `null`. This
behavior, combined with the component's lack of handling for partially parsed dates,
causes the user's typed input to silently disappear from the field if it wasn't fully
parsed into a `Date` object, leading to data loss.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 4799730
6ee7d7c to
944f6ae
Compare
Bumps [react-datepicker](https://github.com/Hacker0x01/react-datepicker) from 7.3.0 to 8.10.0. - [Release notes](https://github.com/Hacker0x01/react-datepicker/releases) - [Commits](Hacker0x01/react-datepicker@v7.3.0...v8.10.0) --- updated-dependencies: - dependency-name: react-datepicker dependency-version: 8.10.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
944f6ae to
79abaf2
Compare
|
Superseded by #1804. |
Bumps react-datepicker from 7.3.0 to 8.10.0.
Release notes
Sourced from react-datepicker's releases.
... (truncated)
Commits
617522c8.10.0c261620Merge pull request #6056 from Hacker0x01/fix/aria-attributes-standard-namesb1f069eSupport standard HTML aria attribute names43acb66Merge pull request #6055 from Hacker0x01/docs/timezone-handling-guidec60ac8aAdd timezone handling documentationc150b04Merge pull request #6054 from Hacker0x01/fix/keyboard-focus-inline-navigation3e53cf4Fix keyboard focus loss during same-month navigation in inline modeca268cfMerge pull request #5948 from tejas-fullstack/fix/59398283ac1test: add test for monthSelectedIn reset when selectsRange is true1092f15Merge remote-tracking branch 'origin/main' into fix/5939Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)