refactor(payment): PAYPAL-6433 hide shipping callbacks

Author: andriiVitvitskyi1990

packages/paypal-commerce-integration/src/paypal-commerce-credit/paypal-commerce-credit-button-strategy.spec.ts

@@ -472,6 +472,33 @@ describe('PayPalCommerceCreditButtonStrategy', () => {
             });
         });
 
+        it('initializes PayPal button to render with shipping options when server side shipping callbacks disabled', async () => {
+            const paymentMethodWithShippingOptionsFeature = {
+                ...paymentMethod,
+                initializationData: {
+                    ...paymentMethod.initializationData,
+                    isHostedCheckoutEnabled: true,
+                    isServerSideShippingCallbacksEnabled: false,
+                },
+            };
+
+            jest.spyOn(
+                paymentIntegrationService.getState(),
+                'getPaymentMethodOrThrow',
+            ).mockReturnValue(paymentMethodWithShippingOptionsFeature);
+
+            await strategy.initialize(initializationOptions);
+
+            expect(paypalSdk.Buttons).toHaveBeenCalledWith({
+                fundingSource: paypalSdk.FUNDING.PAYLATER,
+                style: paypalCommerceCreditOptions.style,
+                createOrder: expect.any(Function),
+                onApprove: expect.any(Function),
+                onShippingAddressChange: expect.any(Function),
+                onShippingOptionsChange: expect.any(Function),
+            });
+        });
+
         it('renders PayPal button if it is eligible', async () => {
             const renderMock = jest.fn();
 

packages/paypal-commerce-integration/src/paypal-commerce-credit/paypal-commerce-credit-button-strategy.ts

@@ -224,7 +224,9 @@ export default class PayPalCommerceCreditButtonStrategy implements CheckoutButto
 
             await this.paypalIntegrationService.submitPayment(methodId, data.orderID);
 
-            onComplete?.();
+            if (onComplete && typeof onComplete === 'function') {
+                onComplete();
+            }
 
             return true; // FIXME: Do we really need to return true here?
         } catch (error) {

packages/paypal-commerce-integration/src/paypal-commerce-credit/paypal-commerce-credit-customer-strategy.ts

@@ -220,7 +220,9 @@ export default class PayPalCommerceCreditCustomerStrategy implements CustomerStr
             await this.paymentIntegrationService.submitOrder({}, { params: { methodId } });
             await this.paypalCommerceIntegrationService.submitPayment(methodId, data.orderID);
 
-            onComplete?.();
+            if (onComplete && typeof onComplete === 'function') {
+                onComplete();
+            }
         } catch (error) {
             this.handleError(error);
         }

packages/paypal-utils/src/paypal-button-creation-service.ts

@@ -141,7 +141,9 @@ class PaypalButtonCreationService {
 
             await this.paypalIntegrationService.submitPayment(methodId, data.orderID);
 
-            onComplete?.();
+            if (onComplete && typeof onComplete === 'function') {
+                onComplete();
+            }
         } catch (error) {
             this.handleError(error);
         }

packages/paypal-utils/src/paypal-integration-service.ts

@@ -138,17 +138,20 @@ export default class PayPalIntegrationService {
     ): Promise<void> {
         const state = this.paymentIntegrationService.getState();
         const cart = state.getCartOrThrow();
-        const consignment = state.getConsignmentsOrThrow()[0];
+        let consignment;
+        if (!isServerSideShippingCallbacksEnabled) {
+            consignment = state.getConsignmentsOrThrow()[0];
+        }
 
         try {
             await this.paypalRequestSender.updateOrder(providerId, {
                 availableShippingOptions: isServerSideShippingCallbacksEnabled
                     ? []
-                    : consignment.availableShippingOptions,
+                    : consignment?.availableShippingOptions,
                 cartId: cart.id,
                 selectedShippingOption: isServerSideShippingCallbacksEnabled
                     ? null
-                    : consignment.selectedShippingOption,
+                    : consignment?.selectedShippingOption,
                 ...(methodId ? { methodId } : {}),
                 ...(orderId ? { orderId } : {}),
             });