Conversation
vitalii-koshovyi
approved these changes
Apr 17, 2026
bc-ania
approved these changes
Apr 17, 2026
PavlenkoM
approved these changes
Apr 17, 2026
payk24
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Affirm Order Submitting only after payment is complete.
Rollout/Rollback
Revert PR, OR experiment disable.
Testing
Manual testing
Note
Medium Risk
Changes the order submission timing in the Affirm payment flow and switches data sources for the Affirm checkout payload, which could affect totals/discounts and sequencing around payment authorization.
Overview
Affirm checkout can now postpone order creation.
AffirmPaymentStrategy.executereadsinitializationData.postponeOrderCreationand conditionally callssubmitOrderbefore or after the Affirm modal succeeds, while still submitting the payment nonce afterwards.Affirm payload generation now uses cart/checkout data instead of order data.
getCheckoutInformationpulls totals andorder_idfromcheckout, and items/discounts fromcart(lineItems,coupons,discountAmount), with tests updated to cover both sequencing modes and expanded item expectations.Reviewed by Cursor Bugbot for commit 3b20088. Bugbot is set up for automated code reviews on this repo. Configure here.