Rename _subscribeAttributeDep and _subscribePropertyDep to full names

Author: scriptogre

src/core/runtime/reactivity.js

@@ -279,28 +279,28 @@ export class Reactivity {
     _subscribeEffect(effect) {
         var reactivity = this;
 
-        for (var [depKey, dependency] of effect.dependencies) {
-            if (dependency.type === "symbol" && dependency.scope === "global") {
-                if (!globalSubscriptions.has(dependency.name)) {
-                    globalSubscriptions.set(dependency.name, new Set());
+        for (var [depKey, dep] of effect.dependencies) {
+            if (dep.type === "symbol" && dep.scope === "global") {
+                if (!globalSubscriptions.has(dep.name)) {
+                    globalSubscriptions.set(dep.name, new Set());
                 }
-                globalSubscriptions.get(dependency.name).add(effect);
+                globalSubscriptions.get(dep.name).add(effect);
 
-            } else if (dependency.type === "symbol" && dependency.scope === "element") {
-                var state = getElementState(dependency.element);
+            } else if (dep.type === "symbol" && dep.scope === "element") {
+                var state = getElementState(dep.element);
                 if (!state.subscriptions) {
                     state.subscriptions = new Map();
                 }
-                if (!state.subscriptions.has(dependency.name)) {
-                    state.subscriptions.set(dependency.name, new Set());
+                if (!state.subscriptions.has(dep.name)) {
+                    state.subscriptions.set(dep.name, new Set());
                 }
-                state.subscriptions.get(dependency.name).add(effect);
+                state.subscriptions.get(dep.name).add(effect);
 
-            } else if (dependency.type === "attribute") {
-                reactivity._subscribeAttributeDep(dependency.element, dependency.name, effect);
+            } else if (dep.type === "attribute") {
+                reactivity._subscribeAttributeDependency(dep.element, dep.name, effect);
 
-            } else if (dependency.type === "property") {
-                reactivity._subscribePropertyDep(dependency.element, dependency.name, effect);
+            } else if (dep.type === "property") {
+                reactivity._subscribePropertyDependency(dep.element, dep.name, effect);
             }
         }
     }
@@ -312,7 +312,7 @@ export class Reactivity {
      * @param {string} attrName
      * @param {Effect} effect
      */
-    _subscribeAttributeDep(element, attrName, effect) {
+    _subscribeAttributeDependency(element, attrName, effect) {
         var reactivity = this;
         var state = getElementState(element);
 
@@ -347,7 +347,7 @@ export class Reactivity {
      * @param {string} propName
      * @param {Effect} effect
      */
-    _subscribePropertyDep(element, propName, effect) {
+    _subscribePropertyDependency(element, propName, effect) {
         var reactivity = this;
         var state = getElementState(element);
 
@@ -376,33 +376,33 @@ export class Reactivity {
 
     /** @param {Effect} effect */
     _unsubscribeEffect(effect) {
-        for (var [depKey, dependency] of effect.dependencies) {
-            if (dependency.type === "symbol" && dependency.scope === "global") {
-                var subs = globalSubscriptions.get(dependency.name);
+        for (var [depKey, dep] of effect.dependencies) {
+            if (dep.type === "symbol" && dep.scope === "global") {
+                var subs = globalSubscriptions.get(dep.name);
                 if (subs) {
                     subs.delete(effect);
                     if (subs.size === 0) {
-                        globalSubscriptions.delete(dependency.name);
+                        globalSubscriptions.delete(dep.name);
                     }
                 }
-            } else if (dependency.type === "symbol" && dependency.scope === "element") {
-                var state = getElementState(dependency.element);
+            } else if (dep.type === "symbol" && dep.scope === "element") {
+                var state = getElementState(dep.element);
                 if (state.subscriptions) {
-                    var subs = state.subscriptions.get(dependency.name);
+                    var subs = state.subscriptions.get(dep.name);
                     if (subs) {
                         subs.delete(effect);
                         if (subs.size === 0) {
-                            state.subscriptions.delete(dependency.name);
+                            state.subscriptions.delete(dep.name);
                         }
                     }
                 }
-            } else if (dependency.type === "attribute" && dependency.element) {
-                var state = getElementState(dependency.element);
-                if (state.attributeObservers && state.attributeObservers[dependency.name]) {
-                    state.attributeObservers[dependency.name].effects.delete(effect);
+            } else if (dep.type === "attribute" && dep.element) {
+                var state = getElementState(dep.element);
+                if (state.attributeObservers && state.attributeObservers[dep.name]) {
+                    state.attributeObservers[dep.name].effects.delete(effect);
                 }
-            } else if (dependency.type === "property" && dependency.element) {
-                var state = getElementState(dependency.element);
+            } else if (dep.type === "property" && dep.element) {
+                var state = getElementState(dep.element);
                 if (state.propertyHandler) {
                     state.propertyHandler.effects.delete(effect);
                 }
@@ -463,18 +463,18 @@ export class Reactivity {
         effect.isStopped = true;
         this._unsubscribeEffect(effect);
         // Clean up per-element listeners and observers if no effects remain
-        for (var [depKey, dependency] of effect.dependencies) {
-            if (dependency.type === "attribute" && dependency.element) {
-                var state = getElementState(dependency.element);
-                if (state.attributeObservers && state.attributeObservers[dependency.name]) {
-                    var obs = state.attributeObservers[dependency.name];
+        for (var [depKey, dep] of effect.dependencies) {
+            if (dep.type === "attribute" && dep.element) {
+                var state = getElementState(dep.element);
+                if (state.attributeObservers && state.attributeObservers[dep.name]) {
+                    var obs = state.attributeObservers[dep.name];
                     if (obs.effects.size === 0) {
                         obs.observer.disconnect();
-                        delete state.attributeObservers[dependency.name];
+                        delete state.attributeObservers[dep.name];
                     }
                 }
-            } else if (dependency.type === "property" && dependency.element) {
-                var state = getElementState(dependency.element);
+            } else if (dep.type === "property" && dep.element) {
+                var state = getElementState(dep.element);
                 if (state.propertyHandler && state.propertyHandler.effects.size === 0) {
                     state.propertyHandler.remove();
                     state.propertyHandler = null;