improve escaping of tag and id in settle lookup#3752
Merged
1cg merged 1 commit intobigskysoftware:devfrom Apr 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
security scanning highlighted potential issues in escaping of id and tag during settle item lookup was only finding the first ' or : and escaping it which would cause it to throw an exception if a user tried. moving to CSS.escape is a simple fix.
Also tidied up class add functions that need standardizing
Corresponding issue:
Testing
added test for double ' in id which was broken before and added a test for 100% code coverage gap.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded