Don't mutate caller's props object in createElement#357
Open
brainkim wants to merge 1 commit into
Open
Conversation
createElement was mutating the incoming props to assign children, which causes circular references when callers reuse the same props object across calls (e.g. vanity-h's proxy-based hyperscript DSL). Spread into a fresh object instead, only when children are present. Also guard the key assignment in jsxAdapter behind a null check to avoid unconditionally adding key: undefined to every props object, which causes unnecessary hidden class transitions. Fixes #356 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createElement was mutating the incoming props to assign children, which causes circular references when callers reuse the same props object across calls (e.g. vanity-h's proxy-based hyperscript DSL). Spread into a fresh object instead, only when children are present.
Also guard the key assignment in jsxAdapter behind a null check to avoid unconditionally adding key: undefined to every props object, which causes unnecessary hidden class transitions.
Fixes #356