Skip to content

ENH: support saving/loading numpy.random.SeedSequence#1097

Merged
ColmTalbot merged 2 commits into
bilby-dev:mainfrom
mj-will:seed-sequence-saving
Jun 26, 2026
Merged

ENH: support saving/loading numpy.random.SeedSequence#1097
ColmTalbot merged 2 commits into
bilby-dev:mainfrom
mj-will:seed-sequence-saving

Conversation

@mj-will

@mj-will mj-will commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Add support for saving/loading numpy.random.SeedSequence objects from results.

Such objects can be present in bilby.core.utils.random.seed is called with SeedSequence, since this adds the seed to the global meta data.

This can lead to issues saving results now the global meta data is always included.

@mj-will mj-will added the enhancement New feature or request label May 29, 2026
@mj-will mj-will added this to the 3.0.0 milestone May 29, 2026
@mj-will

mj-will commented May 29, 2026

Copy link
Copy Markdown
Collaborator Author

Note to self: we should add a test where the global meta data has a SeedSequence

@GregoryAshton GregoryAshton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ColmTalbot ColmTalbot added this pull request to the merge queue Jun 26, 2026
Merged via the queue into bilby-dev:main with commit 1153adc Jun 26, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants